From 74d1b8612f9c1d8c2b2076e7bbd47a12ce927010 Mon Sep 17 00:00:00 2001 From: Diego Medina Date: Tue, 22 Mar 2022 14:22:25 -0300 Subject: [PATCH] fix(sql lab): add quotes when autocompleting table names with spaces in the editor --- .../src/SqlLab/components/AceEditorWrapper/index.tsx | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/superset-frontend/src/SqlLab/components/AceEditorWrapper/index.tsx b/superset-frontend/src/SqlLab/components/AceEditorWrapper/index.tsx index 25da49137ad60..1c684ee996cf6 100644 --- a/superset-frontend/src/SqlLab/components/AceEditorWrapper/index.tsx +++ b/superset-frontend/src/SqlLab/components/AceEditorWrapper/index.tsx @@ -221,11 +221,15 @@ class AceEditorWrapper extends React.PureComponent { this.props.queryEditor.schema, ); } + + let { caption } = data; + if (data.meta === 'table' && caption.includes(' ')) { + caption = `"${caption}"`; + } + // executing https://github.com/thlorenz/brace/blob/3a00c5d59777f9d826841178e1eb36694177f5e6/ext/language_tools.js#L1448 editor.completer.insertMatch( - `${data.caption}${ - ['function', 'schema'].includes(data.meta) ? '' : ' ' - }`, + `${caption}${['function', 'schema'].includes(data.meta) ? '' : ' '}`, ); }, };