Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removes hard-coded colors from legacy-preset-chart-nvd3 #19443

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Removes hard-coded colors from legacy-preset-chart-nvd3.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2022-03-30 at 1 48 52 PM

Screen Shot 2022-03-30 at 1 54 43 PM

TESTING INSTRUCTIONS

Check that the plugin is very similar to the previous version. We may have color, font, and opacity differences due to theme adjustments.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #19443 (3ec8164) into master (fa35109) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 3ec8164 differs from pull request most recent head 7398ccb. Consider uploading reports for the commit 7398ccb to get more accurate results

@@            Coverage Diff             @@
##           master   #19443      +/-   ##
==========================================
- Coverage   66.59%   66.58%   -0.01%     
==========================================
  Files        1670     1670              
  Lines       63888    63894       +6     
  Branches     6510     6510              
==========================================
  Hits        42544    42544              
- Misses      19654    19661       +7     
+ Partials     1690     1689       -1     
Flag Coverage Δ
javascript 51.32% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...plugins/legacy-preset-chart-nvd3/src/ReactNVD3.jsx 0.00% <0.00%> (ø)
...nts/controls/DateFilterControl/DateFilterLabel.tsx 41.41% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa35109...7398ccb. Read the comment docs.

@geido
Copy link
Member

geido commented Mar 31, 2022

/testenv up

@github-actions
Copy link
Contributor

@geido Ephemeral environment spinning up at http://52.12.3.78:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@michael-s-molina michael-s-molina merged commit 47abad8 into apache:master Mar 31, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@villebro villebro added the lts-v1 label Apr 1, 2022
villebro pushed a commit that referenced this pull request Apr 3, 2022
villebro pushed a commit that referenced this pull request Apr 4, 2022
@michael-s-molina michael-s-molina added the global:theming Related to theming Superset label Apr 7, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels global:theming Related to theming Superset lts-v1 size/S 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants