fix(dnd&column): make to fix the blank state issue when only one column select #19651
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19651 +/- ##
==========================================
- Coverage 66.30% 66.30% -0.01%
==========================================
Files 1681 1681
Lines 64408 64406 -2
Branches 6593 6593
==========================================
- Hits 42704 42702 -2
Misses 20020 20020
Partials 1684 1684
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| col => | ||
| !optionSelector.values | ||
| .filter(isColumnMeta) | ||
| .map((val: ColumnMeta) => val.column_name) | ||
| .includes(col.column_name), |
There was a problem hiding this comment.
Did you confirm that we don't have other side effects by removing this filter?
If we really don't need this filter, can you add the reason into PR description so others can get an idea?
There was a problem hiding this comment.
It was supposed to filter out the current value from options when editing metric/column/filter. I suppose we don't really need it so lgtm 👍
|
/testenv up |
|
@kgabryje Ephemeral environment spinning up at http://54.187.169.217:8080. Credentials are |
| () => Object.values(options), | ||
| [optionSelector.values, options], |
There was a problem hiding this comment.
Isn't optionSelector redundant in the dependency array after this?
|
Ephemeral environment shutdown and build artifacts deleted. |
…mn select (apache#19651) (cherry picked from commit c320c29)
|
🏷️ preset:2022.15 |
mistercrunch
added
🏷️ bot
SUMMARY
Single Temporal Column Should Appear in a dropdown instead of Blank State
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
AFTER:
TESTING INSTRUCTIONS
How to reproduce bugs
ADDITIONAL INFORMATION