-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Environment tag #20295
feat: Environment tag #20295
Conversation
53bdfec
to
fa6d7c4
Compare
Codecov Report
@@ Coverage Diff @@
## master #20295 +/- ##
=======================================
Coverage 66.38% 66.38%
=======================================
Files 1766 1766
Lines 67225 67236 +11
Branches 7136 7138 +2
=======================================
+ Hits 44626 44635 +9
- Misses 20774 20775 +1
- Partials 1825 1826 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fa6d7c4
to
cb212a5
Compare
/testenv up |
@rusackas Ephemeral environment spinning up at http://52.11.246.58:8080. Credentials are |
/testenv up |
@rusackas Ephemeral environment spinning up at http://54.202.1.99:8080. Credentials are |
One last nitpick here - there are some hard-coded colors, and it would be great to pull these from the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, this looks great! Just a quick nit, also would you mind writing a test for this tag?
There is already a quick test to make sure the tag appears in the DOM. Is that sufficient or would you like some more tests? |
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is already a quick test to make sure the tag appears in the DOM. Is that sufficient or would you like some more tests?
I totally missed that test somehow, whoops! That test is definitely sufficient, thanks for updating the styles as well 😁
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
It can often be useful to see at a glance what environment you're currently in. This configurable tag can be set to appear based on any environment variable you set. By default, it shows a tag for development or production based on FLASK_ENV.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
After
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION