Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] fix: add user_id to cache key when needed #20301

Conversation

betodealmeida
Copy link
Member

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #20301 (f695816) into master (d1c24f8) will decrease coverage by 11.92%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master   #20301       +/-   ##
===========================================
- Coverage   66.65%   54.73%   -11.93%     
===========================================
  Files        1729     1729               
  Lines       64906    64908        +2     
  Branches     6842     6842               
===========================================
- Hits        43266    35526     -7740     
- Misses      19891    27633     +7742     
  Partials     1749     1749               
Flag Coverage Δ
hive 53.71% <100.00%> (+<0.01%) ⬆️
mysql ?
postgres ?
presto 53.57% <100.00%> (+<0.01%) ⬆️
python 58.10% <100.00%> (-24.68%) ⬇️
sqlite ?
unit 50.15% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/connectors/base/models.py 64.97% <100.00%> (-21.78%) ⬇️
superset/utils/dashboard_import_export.py 0.00% <0.00%> (-100.00%) ⬇️
superset/key_value/commands/upsert.py 0.00% <0.00%> (-89.59%) ⬇️
superset/key_value/commands/update.py 0.00% <0.00%> (-89.37%) ⬇️
superset/key_value/commands/delete.py 0.00% <0.00%> (-85.30%) ⬇️
superset/key_value/commands/delete_expired.py 0.00% <0.00%> (-80.77%) ⬇️
superset/dashboards/commands/importers/v0.py 15.62% <0.00%> (-76.25%) ⬇️
superset/datasets/commands/update.py 25.88% <0.00%> (-68.24%) ⬇️
superset/datasets/commands/create.py 30.18% <0.00%> (-67.93%) ⬇️
superset/datasets/commands/importers/v0.py 24.03% <0.00%> (-67.45%) ⬇️
... and 273 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1c24f8...f695816. Read the comment docs.

@betodealmeida betodealmeida force-pushed the userid_to_cache_key_when_impersonating branch from e06abfa to 855347d Compare June 8, 2022 16:38
@betodealmeida betodealmeida force-pushed the userid_to_cache_key_when_impersonating branch from 855347d to f695816 Compare June 8, 2022 16:41
@betodealmeida
Copy link
Member Author

Closing in lieu of #20114.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant