Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(embedded-SDK): enable CSV download #20416

Merged
merged 2 commits into from
Aug 3, 2022
Merged

feat(embedded-SDK): enable CSV download #20416

merged 2 commits into from
Aug 3, 2022

Conversation

lilykuang
Copy link
Member

SUMMARY

this will enable csv download with this fix #20261

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@justin-tomlinson
Copy link

Be great if this can get into the 2.0.0 release along with #20261

@lilykuang lilykuang requested a review from a team July 25, 2022 19:27
@lilykuang lilykuang merged commit 655646d into apache:master Aug 3, 2022
@lilykuang lilykuang deleted the lily/embedded-download-csv-sdk branch August 3, 2022 17:59
@tys1128
Copy link

tys1128 commented Aug 25, 2022

I think the change has not been published to npm, the lib/index.js file in 0.1.0-alpha.7 version only have 4 iframe.sandbox.add in mountIframe which not include allow-forms and allow-popups, will it be published soon after?

@tys1128
Copy link

tys1128 commented Aug 25, 2022

Oh, I found use @preset-sdk/embedded is OK. = =

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craig-rueda craig-rueda craig-rueda approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 2.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lilykuang @justin-tomlinson @tys1128 @craig-rueda @mistercrunch