Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RLS new db migration downgrade fails on SQLite #20449

Conversation

dpgaspar
Copy link
Member

SUMMARY

Fixes #20432 downgrade for SQLite

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #20449 (bb6d3dd) into master (c79b0d6) will decrease coverage by 0.20%.
The diff coverage is n/a.

❗ Current head bb6d3dd differs from pull request most recent head 0d32c73. Consider uploading reports for the commit 0d32c73 to get more accurate results

@@            Coverage Diff             @@
##           master   #20449      +/-   ##
==========================================
- Coverage   66.72%   66.52%   -0.21%     
==========================================
  Files        1740     1740              
  Lines       65175    65175              
  Branches     6895     6895              
==========================================
- Hits        43486    43355     -131     
- Misses      19940    20071     +131     
  Partials     1749     1749              
Flag Coverage Δ
hive ?
mysql 82.26% <ø> (ø)
postgres ?
presto ?
python 82.35% <ø> (-0.42%) ⬇️
sqlite 82.12% <ø> (ø)
unit 50.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/sql_validators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
superset/sql_validators/__init__.py 80.00% <0.00%> (-20.00%) ⬇️
superset/db_engine_specs/hive.py 70.22% <0.00%> (-15.65%) ⬇️
superset/db_engine_specs/postgres.py 90.67% <0.00%> (-5.94%) ⬇️
superset/db_engine_specs/presto.py 83.64% <0.00%> (-5.39%) ⬇️
superset/reports/commands/log_prune.py 85.71% <0.00%> (-3.58%) ⬇️
superset/databases/commands/validate_sql.py 92.00% <0.00%> (-2.00%) ⬇️
superset/commands/importers/v1/utils.py 92.20% <0.00%> (-1.30%) ⬇️
superset/connectors/sqla/models.py 89.17% <0.00%> (-1.18%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c79b0d6...0d32c73. Read the comment docs.

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpgaspar dpgaspar merged commit ba4ba02 into apache:master Jun 21, 2022
@dpgaspar dpgaspar deleted the danielgaspar/sc-50677/superset-create-unique-name-and-disallow2 branch June 21, 2022 12:07
akshatsri pushed a commit to charan1314/superset that referenced this pull request Jul 19, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants