Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Set table viz default row limit to 1000 #20475

Conversation

diegomedina248
Copy link
Contributor

SUMMARY

Table viz default of row limit 10000 is too high and rough on the browser - 1000 is a better default.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

--

TESTING INSTRUCTIONS

Create a new table chart and ensure the default limit is set at 1000.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #20475 (231d0fd) into master (a169b60) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #20475   +/-   ##
=======================================
  Coverage   66.75%   66.75%           
=======================================
  Files        1740     1740           
  Lines       65149    65149           
  Branches     6898     6898           
=======================================
  Hits        43492    43492           
  Misses      19908    19908           
  Partials     1749     1749           
Flag Coverage Δ
javascript 51.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nd/plugins/plugin-chart-table/src/controlPanel.tsx 43.47% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a169b60...231d0fd. Read the comment docs.

@zhaoyongjie zhaoyongjie self-requested a review June 23, 2022 08:41
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for codes looks good. but seems like users actually need pagination in table viz so to reduce browser rendering load.

@rusackas rusackas merged commit ac01a1b into apache:master Jul 7, 2022
akshatsri pushed a commit to charan1314/superset that referenced this pull request Jul 19, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants