-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(database-modal): Refresh Data when importing #20523
Conversation
superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #20523 +/- ##
==========================================
- Coverage 66.74% 66.74% -0.01%
==========================================
Files 1751 1751
Lines 65440 65441 +1
Branches 6912 6913 +1
==========================================
Hits 43677 43677
- Misses 20014 20015 +1
Partials 1749 1749
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
- Add missing invocation to onDatabaseAdd after importing DB from file - Add keys to our IconButtons
- Reduce if clause so it's more concise
4c84d2f
to
8eb07a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* Database Modal: - Add missing invocation to onDatabaseAdd after importing DB from file - Add keys to our IconButtons * Database Modal: - Reduce if clause so it's more concise
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION