Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(database-modal): Refresh Data when importing #20523

Merged
merged 2 commits into from
Jun 28, 2022

Conversation

Antonio-RiveroMartnez
Copy link
Member

SUMMARY

  • Add missing invocation to onDatabaseAdd after importing DB from file so the table refreshes
  • Add keys to our IconButtons so we avoid having warnings when the list is rendered

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
error

After:
test

TESTING INSTRUCTIONS

  1. Visit the "Databases" page and hit the "+Database+ button
  2. Click on "Import database from file" and select a database
  3. Check the list of databases so it renders the new DB without need for manual page reload

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #20523 (c77b32c) into master (e12ee59) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head c77b32c differs from pull request most recent head 8eb07a6. Consider uploading reports for the commit 8eb07a6 to get more accurate results

@@            Coverage Diff             @@
##           master   #20523      +/-   ##
==========================================
- Coverage   66.74%   66.74%   -0.01%     
==========================================
  Files        1751     1751              
  Lines       65440    65441       +1     
  Branches     6912     6913       +1     
==========================================
  Hits        43677    43677              
- Misses      20014    20015       +1     
  Partials     1749     1749              
Flag Coverage Δ
javascript 51.84% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/views/CRUD/data/database/DatabaseModal/index.tsx 32.07% <0.00%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e12ee59...8eb07a6. Read the comment docs.

- Add missing invocation to onDatabaseAdd after importing DB from file
- Add keys to our IconButtons
- Reduce if clause so it's more concise
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas rusackas merged commit 850f5fa into apache:master Jun 28, 2022
@Antonio-RiveroMartnez Antonio-RiveroMartnez deleted the FIX-50971 branch July 8, 2022 12:20
akshatsri pushed a commit to charan1314/superset that referenced this pull request Jul 19, 2022
* Database Modal:

- Add missing invocation to onDatabaseAdd after importing DB from file
- Add keys to our IconButtons

* Database Modal:

- Reduce if clause so it's more concise
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels Preset-Patch size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants