-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Bar stacking on v2 doesn't work if the x-axis is value type #20591
fix: Bar stacking on v2 doesn't work if the x-axis is value type #20591
Conversation
b6e16a2
to
cfb8974
Compare
Codecov Report
@@ Coverage Diff @@
## master #20591 +/- ##
==========================================
- Coverage 66.79% 66.78% -0.01%
==========================================
Files 1754 1754
Lines 65561 65575 +14
Branches 6933 6939 +6
==========================================
+ Hits 43793 43796 +3
- Misses 20014 20024 +10
- Partials 1754 1755 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@zhaoyongjie Ephemeral environment spinning up at http://54.184.228.100:8080. Credentials are |
/testenv up FEATURE_GENERIC_CHART_AXES=true |
@zhaoyongjie Ephemeral environment spinning up at http://35.89.160.47:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The root cause of the case was multiple metrics applied in the stack bar chart.
- The bar chart in the Echart supports timeseries as the x-axis to stack. e.g.
barchart.timeseries.stack.mov
- we should find a way to support multiple metrics in the bar chart, or just avoid applying multiple metrics in the stacked bar chart, instead of removing the entire stack feature in the timeseries barchart.
@diegomedina248 @zhaoyongjie should we set up a time to sync on this and get to the bottom of it? |
Closed in favor on #20805 |
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
When
GENERIC_CHART_AXES
is enabled, stacking on bar chart v2 is not working correctly in all cases.The reason is that bar stacking is supported by echarts only for categorical types.
Source: apache/echarts#15102
This PR hides that feature if the axis is not categorical.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
Screen.Recording.2022-07-01.at.15.06.09.mov
After:
new.mov
TESTING INSTRUCTIONS
GENERIC_CHART_AXES
.Ensure the stack option is only available for categorical types, and that it works as expected.
ADDITIONAL INFORMATION