-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: controls validator glitch #20623
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20623 +/- ##
=======================================
Coverage 66.82% 66.83%
=======================================
Files 1752 1752
Lines 65616 65618 +2
Branches 6938 6938
=======================================
+ Hits 43849 43853 +4
+ Misses 20007 20006 -1
+ Partials 1760 1759 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@zhaoyongjie Container image not yet published for this PR. Please try again when build is complete. |
@zhaoyongjie Ephemeral environment creation failed. Please check the Actions logs for details. |
/testenv up |
@zhaoyongjie Container image not yet published for this PR. Please try again when build is complete. |
@zhaoyongjie Ephemeral environment creation failed. Please check the Actions logs for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
SUMMARY
There is a glitch when switching viz from
big number
totable
, the validator error message can not work correctly in Table.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
After
big.number.-.table.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION