Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: controls validator glitch #20623

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

zhaoyongjie
Copy link
Member

SUMMARY

There is a glitch when switching viz from big number to table, the validator error message can not work correctly in Table.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

image

After

big.number.-.table.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@zhaoyongjie zhaoyongjie requested a review from kgabryje July 6, 2022 12:18
@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #20623 (a6d6674) into master (f38dd1d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #20623   +/-   ##
=======================================
  Coverage   66.82%   66.83%           
=======================================
  Files        1752     1752           
  Lines       65616    65618    +2     
  Branches     6938     6938           
=======================================
+ Hits        43849    43853    +4     
+ Misses      20007    20006    -1     
+ Partials     1760     1759    -1     
Flag Coverage Δ
javascript 51.85% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/src/explore/controlUtils/standardizedFormData.ts 100.00% <100.00%> (ø)
...nd/plugins/plugin-chart-table/src/controlPanel.tsx 46.37% <0.00%> (+2.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f38dd1d...a6d6674. Read the comment docs.

@zhaoyongjie zhaoyongjie requested a review from jinghua-qa July 6, 2022 14:14
@zhaoyongjie
Copy link
Member Author

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2022

@zhaoyongjie Container image not yet published for this PR. Please try again when build is complete.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2022

@zhaoyongjie Ephemeral environment creation failed. Please check the Actions logs for details.

@zhaoyongjie
Copy link
Member Author

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2022

@zhaoyongjie Container image not yet published for this PR. Please try again when build is complete.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2022

@zhaoyongjie Ephemeral environment creation failed. Please check the Actions logs for details.

@zhaoyongjie zhaoyongjie requested a review from stephenLYZ July 7, 2022 04:06
Copy link
Member

@stephenLYZ stephenLYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zhaoyongjie zhaoyongjie merged commit 34e1336 into apache:master Jul 7, 2022
akshatsri pushed a commit to charan1314/superset that referenced this pull request Jul 19, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants