-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(databases): Display for credentials input #20637
Conversation
b552fe2
to
719b69f
Compare
/testenv up |
@yousoph Container image not yet published for this PR. Please try again when build is complete. |
@yousoph Ephemeral environment creation failed. Please check the Actions logs for details. |
- Since our DatabaseConnectionForm is wrapped in a AntD Form, we need to ensure our custom design is applied in the upload input instead of AntD default one for file input type=file.
719b69f
to
b8a6e34
Compare
Codecov Report
@@ Coverage Diff @@
## master #20637 +/- ##
=======================================
Coverage 66.79% 66.79%
=======================================
Files 1753 1753
Lines 65618 65618
Branches 6952 6952
=======================================
Hits 43831 43831
Misses 20023 20023
Partials 1764 1764
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
/testenv up |
@rusackas Container image not yet published for this PR. Please try again when build is complete. |
@rusackas Ephemeral environment creation failed. Please check the Actions logs for details. |
- Since our DatabaseConnectionForm is wrapped in a AntD Form, we need to ensure our custom design is applied in the upload input instead of AntD default one for file input type=file. (cherry picked from commit e331640)
- Since our DatabaseConnectionForm is wrapped in a AntD Form, we need to ensure our custom design is applied in the upload input instead of AntD default one for file input type=file. (cherry picked from commit e331640)
- Since our DatabaseConnectionForm is wrapped in a AntD Form, we need to ensure our custom design is applied in the upload input instead of AntD default one for file input type=file. (cherry picked from commit e331640)
- Since our DatabaseConnectionForm is wrapped in a AntD Form, we need to ensure our custom design is applied in the upload input instead of AntD default one for file input type=file.
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
AFTER:
TESTING INSTRUCTIONS
UPLOAD CREDENTIALS
) is hidden and only the button is visible.ADDITIONAL INFORMATION