Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Published Dashboard without charts don't show up for non admin users #20638

Merged

Conversation

diegomedina248
Copy link
Contributor

SUMMARY

Dashboards created & published that do not contain charts (most common ones, only with markdown content) don't show up in the dashboard list for non admin users.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screen.Recording.2022-07-07.at.09.15.16.mov

After:

new.mov

TESTING INSTRUCTIONS

  1. Create a dashboard with only markdown content.
  2. Publish the dashboard.

The published dashboard should appear in the dashboard list for Alpha users.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@diegomedina248 diegomedina248 force-pushed the fix/dashboard-without-charts-inlist branch from ac0a2bb to 079d36f Compare July 7, 2022 12:26
@diegomedina248 diegomedina248 force-pushed the fix/dashboard-without-charts-inlist branch from 079d36f to 7954e2a Compare July 14, 2022 05:19
@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #20638 (09cfe07) into master (6b0bb80) will decrease coverage by 11.60%.
The diff coverage is n/a.

❗ Current head 09cfe07 differs from pull request most recent head c56972a. Consider uploading reports for the commit c56972a to get more accurate results

@@             Coverage Diff             @@
##           master   #20638       +/-   ##
===========================================
- Coverage   66.83%   55.22%   -11.61%     
===========================================
  Files        1750     1750               
  Lines       65894    65894               
  Branches     7017     7017               
===========================================
- Hits        44041    36393     -7648     
- Misses      20067    27715     +7648     
  Partials     1786     1786               
Flag Coverage Δ
hive 53.95% <ø> (ø)
mysql ?
postgres ?
presto 53.81% <ø> (ø)
python 58.79% <ø> (-24.20%) ⬇️
sqlite ?
unit 51.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/dashboards/filters.py 48.75% <ø> (-45.00%) ⬇️
superset/sql_parse.py 95.90% <ø> (-1.17%) ⬇️
superset/utils/dashboard_import_export.py 0.00% <0.00%> (-100.00%) ⬇️
superset/key_value/commands/update.py 0.00% <0.00%> (-88.89%) ⬇️
superset/key_value/commands/delete.py 0.00% <0.00%> (-85.30%) ⬇️
superset/key_value/commands/delete_expired.py 0.00% <0.00%> (-80.77%) ⬇️
superset/dashboards/commands/importers/v0.py 15.62% <0.00%> (-76.25%) ⬇️
superset/datasets/commands/update.py 25.30% <0.00%> (-68.68%) ⬇️
superset/datasets/commands/create.py 29.41% <0.00%> (-68.63%) ⬇️
superset/datasets/commands/importers/v0.py 24.03% <0.00%> (-67.45%) ⬇️
... and 277 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b0bb80...c56972a. Read the comment docs.

@diegomedina248 diegomedina248 force-pushed the fix/dashboard-without-charts-inlist branch from 7954e2a to 00b12c9 Compare July 14, 2022 05:47
@diegomedina248 diegomedina248 force-pushed the fix/dashboard-without-charts-inlist branch from 00b12c9 to c56972a Compare July 14, 2022 13:16
@rusackas rusackas merged commit 8b354b4 into apache:master Jul 27, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels Preset-Patch size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants