Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove legacy treemap/area #20639

Closed
wants to merge 3 commits into from

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Jul 7, 2022

SUMMARY

Remove unused viz-plugins

  1. Legacy TreeMap
  2. NVD3 Area

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

CI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@john-bodley
Copy link
Member

@zhaoyongjie are we 100% sure these are unused? If not it seems like a migration would be necessary conditional on the fact that parity exists between the old NVD3 and new ECharts charts.

@zhaoyongjie
Copy link
Member Author

zhaoyongjie commented Jul 8, 2022

@john-bodley thanks for the tip, I updated PR, and the legacy plugins were been kept. when the PR is merged, I will turn this open.

@zhaoyongjie zhaoyongjie force-pushed the chore/remove_charts branch from 5337aad to 6cf1c91 Compare July 8, 2022 12:00
@zhaoyongjie zhaoyongjie changed the title chore: remove legacy treemap/area/boxplot/pie chore: remove legacy treemap/area Jul 8, 2022
@zhaoyongjie zhaoyongjie marked this pull request as ready for review July 8, 2022 12:02
@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #20639 (b6d2f08) into master (4e6e87f) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #20639   +/-   ##
=======================================
  Coverage   66.79%   66.79%           
=======================================
  Files        1754     1754           
  Lines       65874    65862   -12     
  Branches     7030     7030           
=======================================
- Hits        43999    43994    -5     
+ Misses      20086    20079    -7     
  Partials     1789     1789           
Flag Coverage Δ
hive 53.87% <ø> (-0.01%) ⬇️
mysql ?
postgres 82.55% <ø> (+0.10%) ⬆️
presto 53.73% <ø> (-0.01%) ⬇️
python 82.90% <ø> (+0.02%) ⬆️
sqlite ?
unit 50.96% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-frontend/src/visualizations/presets/MainPreset.js 100.00% <ø> (ø)
superset/examples/birth_names.py 71.55% <ø> (ø)
superset/examples/world_bank.py 31.57% <ø> (ø)
...ns/legacy-plugin-chart-treemap/src/controlPanel.ts 0.00% <0.00%> (-100.00%) ⬇️
...d/plugins/legacy-plugin-chart-treemap/src/index.js 0.00% <0.00%> (-66.67%) ⬇️
...plugins/legacy-preset-chart-nvd3/src/Area/index.js 33.33% <0.00%> (-33.34%) ⬇️
superset/db_engine_specs/sqlite.py 91.89% <0.00%> (-5.41%) ⬇️
superset/common/utils/dataframe_utils.py 90.47% <0.00%> (-4.77%) ⬇️
superset/db_engine_specs/mysql.py 93.97% <0.00%> (-3.62%) ⬇️
superset/utils/celery.py 86.20% <0.00%> (-3.45%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e6e87f...b6d2f08. Read the comment docs.

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Jul 8, 2022
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jul 9, 2022
@zhaoyongjie zhaoyongjie marked this pull request as draft July 11, 2022 07:37
@zhaoyongjie zhaoyongjie mentioned this pull request Oct 11, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants