Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: small fixes for OAuth #20640

Merged
merged 1 commit into from
Jul 7, 2022
Merged

docs: small fixes for OAuth #20640

merged 1 commit into from
Jul 7, 2022

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Jul 7, 2022

SUMMARY

A couple of very small fixes for OAuth docs

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dpgaspar dpgaspar mentioned this pull request Jul 7, 2022
Closed
9 tasks
michael-s-molina
michael-s-molina approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpgaspar dpgaspar merged commit 3b4924f into apache:master Jul 7, 2022
@dpgaspar dpgaspar deleted the docs/improve-oauth branch July 7, 2022 14:01
akshatsri pushed a commit to charan1314/superset that referenced this pull request Jul 19, 2022
@dpgaspar @akshatsri
docs: small fixes for OAuth (apache#20640)
3d0d0ca
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

@rusackas rusackas Awaiting requested review from rusackas

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 2.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dpgaspar @michael-s-molina @mistercrunch