Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove unnecessary line item #20657

Merged
merged 1 commit into from
Jul 9, 2022
Merged

docs: Remove unnecessary line item #20657

merged 1 commit into from
Jul 9, 2022

Conversation

john-bodley
Copy link
Member

@john-bodley john-bodley commented Jul 8, 2022

SUMMARY

I don't believe #20170, i.e., a new feature, needs to be included in UPDATING.md. This file is primarily used for breaking changes or changes where feature flag states change.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #20657 (7d039fd) into master (0ce0c6e) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #20657      +/-   ##
==========================================
- Coverage   66.83%   66.81%   -0.03%     
==========================================
  Files        1753     1753              
  Lines       65808    65808              
  Branches     7001     7001              
==========================================
- Hits        43984    43968      -16     
- Misses      20035    20056      +21     
+ Partials     1789     1784       -5     
Flag Coverage Δ
hive 53.88% <ø> (ø)
javascript 51.95% <ø> (-0.05%) ⬇️
mysql 82.38% <ø> (ø)
postgres 82.45% <ø> (ø)
presto 53.74% <ø> (ø)
python 82.89% <ø> (ø)
sqlite 82.24% <ø> (ø)
unit 50.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rd/components/nativeFilters/FilterBar/keyValue.tsx 18.51% <0.00%> (-22.23%) ⬇️
...board/components/nativeFilters/FilterBar/index.tsx 60.58% <0.00%> (-7.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ce0c6e...7d039fd. Read the comment docs.

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it's my bad. thanks for fixing it.

@zhaoyongjie zhaoyongjie merged commit 542fdb2 into master Jul 9, 2022
akshatsri pushed a commit to charan1314/superset that referenced this pull request Jul 19, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the john-bodley-patch-4 branch March 26, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants