Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change dataset functionality in Explore #20751

Merged
merged 2 commits into from
Jul 18, 2022

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Jul 18, 2022

SUMMARY

Update function reference for explore to change Datasets

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@pkdotson pkdotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #20751 (b610014) into master (92f3621) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #20751      +/-   ##
==========================================
- Coverage   66.26%   66.26%   -0.01%     
==========================================
  Files        1754     1754              
  Lines       66673    66678       +5     
  Branches     7049     7049              
==========================================
+ Hits        44180    44181       +1     
- Misses      20696    20700       +4     
  Partials     1797     1797              
Flag Coverage Δ
javascript 51.92% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...re/components/controls/DatasourceControl/index.jsx 75.24% <0.00%> (ø)
...set-frontend/src/explore/actions/exploreActions.ts 47.72% <0.00%> (-2.28%) ⬇️
...et-frontend/src/explore/reducers/exploreReducer.js 39.34% <0.00%> (-0.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92f3621...b610014. Read the comment docs.

@hughhhh hughhhh merged commit 1101922 into apache:master Jul 18, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants