fix: Ensure consistent rollback logic for failed SQL operations #20811
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR ensures we consistently handle rollbacks when an error occurs. Throughout the code there's inconsistent logic of the form:
as well as:
This PR—by way of
git grep -B 1 rollback
—removes the unnecessaryif commit
checkout before a rollback because we want to rollback any operation which failed—pre commit—in the transaction regardless of whether we're planning to commit, i.e., save the state.Regarding commits per here it's worth noting that once committed a rollback is not viable.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
CI.
ADDITIONAL INFORMATION