Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adding extraConfig to worker deployment #20828 #20829

Merged
merged 3 commits into from
Jul 25, 2022
Merged

fix: adding extraConfig to worker deployment #20828 #20829

merged 3 commits into from
Jul 25, 2022

Conversation

cdreier
Copy link
Contributor

@cdreier cdreier commented Jul 22, 2022

Fixes #20828

github-actions[bot]
github-actions bot reviewed Jul 22, 2022
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️
We hope to see you in our Slack community too!

@craig-rueda
Copy link
Member

@cdreier - can you pls bump the chart version?

@cdreier
Copy link
Contributor Author

cdreier commented Jul 22, 2022

thanks a lot for your support and fast response!

@cdreier cdreier changed the title #20828 adding extraConfig to worker deployment fix: adding extraConfig to worker deployment #20828 Jul 22, 2022
@cdreier
Copy link
Contributor Author

cdreier commented Jul 25, 2022

@craig-rueda is there a chance we get this merged this week? would help us a lot to remove temporary workarounds - or is anything missing?

@craig-rueda craig-rueda merged commit 3f943ff into apache:master Jul 25, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@craig-rueda craig-rueda craig-rueda approved these changes

@dpgaspar dpgaspar Awaiting requested review from dpgaspar dpgaspar is a code owner

@villebro villebro Awaiting requested review from villebro villebro is a code owner

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

volumeMounts for extraConfigs are missing in the deployment-worker.yaml
3 participants
@cdreier @craig-rueda @mistercrunch