feat: Creating dataset/add route #20869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AAfghahi
force-pushed
the
arash.afghahi/sc-52802/create-route-for-dataset-id-and-dataset-add
branch
from
21848ca to
a054648
Compare
Codecov Report
@@ Coverage Diff @@
## master #20869 +/- ##
==========================================
+ Coverage 66.32% 67.14% +0.81%
==========================================
Files 1756 1768 +12
Lines 66767 72083 +5316
Branches 7060 7898 +838
==========================================
+ Hits 44286 48400 +4114
- Misses 20683 21714 +1031
- Partials 1798 1969 +171
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
AAfghahi
force-pushed
the
arash.afghahi/sc-52802/create-route-for-dataset-id-and-dataset-add
branch
from
a054648 to
3c99d73
Compare
eschutho
reviewed
Jul 27, 2022
superset-frontend/src/views/CRUD/data/dataset/DatasetEditor/DatasetPanel/DatasetPanel.tsx
Outdated
Show resolved
Hide resolved
eschutho
reviewed
Jul 27, 2022
superset-frontend/src/views/CRUD/data/dataset/DatasetEditor/index.tsx
Outdated
Show resolved
Hide resolved
eschutho
reviewed
Jul 27, 2022
AAfghahi
force-pushed
the
arash.afghahi/sc-52802/create-route-for-dataset-id-and-dataset-add
branch
2 times, most recently
from
36cbb2f to
edf1085
Compare
eschutho
reviewed
Jul 28, 2022
|
|
||
| @expose("/add/") | ||
| @has_access | ||
| @permission_name("read") |
There was a problem hiding this comment.
what sort of permissions does this map to? Who has permission to read this page? Wouldn't this be edit?
|
/testenv up |
|
@eschutho Ephemeral environment spinning up at http://54.188.25.138:8080. Credentials are |
AAfghahi
force-pushed
the
arash.afghahi/sc-52802/create-route-for-dataset-id-and-dataset-add
branch
from
edf1085 to
f4674da
Compare
AAfghahi
force-pushed
the
arash.afghahi/sc-52802/create-route-for-dataset-id-and-dataset-add
branch
from
f4674da to
3d69718
Compare
superset-frontend/src/views/CRUD/data/dataset/DatasetPage/RightPanel/index.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/views/CRUD/data/dataset/DatasetPage/index.tsx
Outdated
Show resolved
Hide resolved
…x.tsx Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
…tPanel/index.tsx Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
eschutho
approved these changes
Aug 1, 2022
|
Ephemeral environment shutdown and build artifacts deleted. |
9 tasks
mistercrunch
added
🏷️ bot
mistercrunch
deleted the
arash.afghahi/sc-52802/create-route-for-dataset-id-and-dataset-add
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR creates the groundwork for a new dataset editor that is going to be rolled out in the next couple of weeks. Currently it is gated behind the 'testing' query parameter, if this is not present users will be redirected to the welcome page.
Also created are very basic level components that will be populated as the feature gets more filled out, but are currently empty. Each component is in its own folder which will have the component + testing in it.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION