fix: add having_druid back into the chart schema

[eschutho]

SUMMARY

The having_druid key still exists in some query table extras json blobs in the database. We removed the key from the chart schema in the native druid cleanup work #20338 but need to run a migration in order to remove the key permanently from query objects in the database. This PR is a temporary fix to add the property back into the schema for an easier cherry prior to the db migration. We need to remove this property again and run the migration together next.

The error that we're seeing is on some reports that still have the old key{"message":"Request is incorrect: {'queries': {0: {'extras': {'having_druid': ['Unknown field.']}}}}"}

TESTING INSTRUCTIONS

I added having_druid to an existing test and validated that it failed and then fixed the code and validated that it passed.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[john-bodley]

😿 to see Druid NoSQL make a brief—and hopefully short lived—return.

[eschutho]

😿 to see Druid NoSQL make a brief—and hopefully short lived—return.

Ha, yeah, I know. 😢 We'll do a fast-follow migration.

[codecov]

Codecov Report

Merging #20879 (f321123) into master (1b577d1) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #20879      +/-   ##
==========================================
+ Coverage   66.23%   66.25%   +0.02%     
==========================================
  Files        1757     1758       +1     
  Lines       66978    66988      +10     
  Branches     7117     7117              
==========================================
+ Hits        44360    44386      +26     
+ Misses      20801    20785      -16     
  Partials     1817     1817              

Flag	Coverage Δ
hive	53.28% <100.00%> (+0.02%)	⬆️
mysql	81.07% <100.00%> (+<0.01%)	⬆️
postgres	81.14% <100.00%> (+<0.01%)	⬆️
presto	53.14% <100.00%> (+0.02%)	⬆️
python	81.59% <100.00%> (+0.05%)	⬆️
sqlite	79.76% <100.00%> (?)
unit	50.29% <100.00%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/charts/schemas.py	99.35% <100.00%> (+<0.01%)	⬆️
superset/reports/commands/exceptions.py	97.97% <0.00%> (-0.98%)	⬇️
superset/models/dashboard.py	76.07% <0.00%> (-0.21%)	⬇️
superset/reports/commands/execute.py	91.41% <0.00%> (-0.19%)	⬇️
superset/reports/api.py	90.22% <0.00%> (ø)
superset/reports/commands/base.py	92.30% <0.00%> (ø)
superset/reports/commands/alert.py	96.59% <0.00%> (ø)
superset/reports/commands/delete.py	90.32% <0.00%> (ø)
superset/reports/commands/update.py	89.55% <0.00%> (ø)
superset/reports/commands/bulk_delete.py	90.32% <0.00%> (ø)
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

[sadpandajoe]

🏷️ preset:2022.29