fix: Address performance regression introduced in #11785

[john-bodley]

SUMMARY

This PR fixes a SQL Lab performance regression introduced in https://github.com/apache/superset/pull/11785—a mere two years ago—which impacts the populating the tables in the SQL Lab LHS.

Specially at Airbnb for the Presto database the following line

dataset_tables = {table.name: table for table in database.tables} 

would take over 5 seconds to execute given we have over 100,000 tables registered with said database in Superset. The fix is to bypass the SQLAlchemy ORM and fetch only the subset of relevant tables using the SQLAlchemy Query API. The resulting refactor reduced the statement execution time down to << 0.01 seconds.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[john-bodley]

The logic needed to be translated into a function that SQLAlchemy could understand as we're using this hybrid property as a filter.

[codecov]

Codecov Report

Merging #20893 (e738f8c) into master (383313b) will decrease coverage by 11.47%.
The diff coverage is 78.57%.

❗ Current head e738f8c differs from pull request most recent head a9d2e54. Consider uploading reports for the commit a9d2e54 to get more accurate results

@@             Coverage Diff             @@
##           master   #20893       +/-   ##
===========================================
- Coverage   66.27%   54.80%   -11.48%     
===========================================
  Files        1758     1758               
  Lines       67072    67072               
  Branches     7122     7122               
===========================================
- Hits        44453    36759     -7694     
- Misses      20800    28494     +7694     
  Partials     1819     1819               

Flag	Coverage Δ
hive	53.25% <64.28%> (+<0.01%)	⬆️
mysql	?
postgres	?
presto	53.15% <64.28%> (+<0.01%)	⬆️
python	57.84% <78.57%> (-23.72%)	⬇️
sqlite	?
unit	50.25% <78.57%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/dashboards/api.py	51.15% <0.00%> (-41.33%)	⬇️
superset/views/core.py	34.39% <0.00%> (-41.20%)	⬇️
superset/connectors/sqla/models.py	77.85% <100.00%> (-12.49%)	⬇️
superset/models/sql_lab.py	74.16% <100.00%> (-4.59%)	⬇️
superset/utils/core.py	62.88% <100.00%> (-27.35%)	⬇️
superset/utils/dashboard_import_export.py	0.00% <0.00%> (-100.00%)	⬇️
superset/key_value/commands/update.py	0.00% <0.00%> (-88.89%)	⬇️
superset/key_value/commands/delete.py	0.00% <0.00%> (-85.30%)	⬇️
superset/key_value/commands/delete_expired.py	0.00% <0.00%> (-80.77%)	⬇️
superset/dashboards/commands/importers/v0.py	15.62% <0.00%> (-76.25%)	⬇️
... and 283 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

[etr2460]

thanks for the fix!