fix(plugin-chart-pivot-table): Invalid Formats Date Fields #20909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a custom date field value converted in a string format, some aggregators truncated to the first four digits. This is caused by the parseFloat function which converts to first matched number rather than NaN(Not-A-Number) value. This commit replaces the parseFloat by Number wrapper to handle this case correctly.
ktmud
approved these changes
Jul 28, 2022
Codecov Report
@@ Coverage Diff @@
## master #20909 +/- ##
=======================================
Coverage 66.21% 66.21%
=======================================
Files 1758 1758
Lines 67009 67009
Branches 7107 7107
=======================================
Hits 44369 44369
Misses 20818 20818
Partials 1822 1822
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
justinpark
added a commit
to airbnb/superset-fork
that referenced
this pull request
Jul 29, 2022
) When a custom date field value converted in a string format, some aggregators truncated to the first four digits. This is caused by the parseFloat function which converts to first matched number rather than NaN(Not-A-Number) value. This commit replaces the parseFloat by Number wrapper to handle this case correctly.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When a custom date field value converted in a string format, some aggregators truncated to the first four digits.
This is caused by the parseFloat function which converts to first matched number rather than NaN (Not-A-Number) value.
This commit replaces the parseFloat by Number wrapper to handle this case correctly.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
storybook
ADDITIONAL INFORMATION