Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip row if created_at_fk is null #20939

Merged
merged 1 commit into from
Aug 2, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -22,16 +22,17 @@

"""

# revision identifiers, used by Alembic.
revision = "409c7b420ab0"
down_revision = "a39867932713"

from alembic import op
from sqlalchemy import and_, Column, insert, Integer
from sqlalchemy.ext.declarative import declarative_base

# revision identifiers, used by Alembic.
from superset import db

revision = "409c7b420ab0"
down_revision = "a39867932713"


Base = declarative_base()


Expand Down Expand Up @@ -95,7 +96,7 @@ def upgrade():
DatasetUser.user_id == Dataset.created_by_fk,
),
)
.filter(DatasetUser.dataset_id == None),
.filter(DatasetUser.dataset_id == None, Dataset.created_by_fk != None),
)
)

Expand Down