Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-echart-timeseries): legend trancated on show extra controls #21017

Conversation

justinpark
Copy link
Member

SUMMARY

When extra controls are enabled in an echart timeseries chart, the x-axis legend is truncated.
This is caused by the extra spaces for the controllers which pushes down the chart without resizing.
This commit adds the logic to calculate the offset space for the extra controls.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

extraControl--before

After:

extraControl--after

TESTING INSTRUCTIONS

storybook

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@ktmud ktmud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #21017 (7915868) into master (2c8867e) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #21017      +/-   ##
==========================================
- Coverage   66.33%   66.33%   -0.01%     
==========================================
  Files        1767     1767              
  Lines       67348    67353       +5     
  Branches     7144     7145       +1     
==========================================
  Hits        44677    44677              
- Misses      20843    20848       +5     
  Partials     1828     1828              
Flag Coverage Δ
javascript 52.11% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...chart-echarts/src/Timeseries/EchartsTimeseries.tsx 0.00% <0.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@justinpark justinpark changed the title fix(plugin-echart-timeseries: legend trancated on show extra controls fix(plugin-echart-timeseries): legend trancated on show extra controls Aug 8, 2022
@stephenLYZ stephenLYZ merged commit 9114175 into apache:master Aug 9, 2022
@justinpark justinpark deleted the fix--echart-timeseries-area-truncated-on-extra-chart-options branch August 11, 2022 18:51
justinpark added a commit to airbnb/superset-fork that referenced this pull request Aug 11, 2022
john-bodley pushed a commit to airbnb/superset-fork that referenced this pull request Aug 17, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XL 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants