Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unable to show view as table modal #21025

Merged
merged 1 commit into from
Aug 10, 2022
Merged

fix: unable to show view as table modal #21025

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions superset-frontend/src/explore/components/DataTablesPane/components/useResultsPane.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ const Error = styled.pre`
margin-top: ${({ theme }) => `${theme.gridUnit * 4}px`};
`;

const cache = new WeakSet();
const cache = new WeakMap();

export const useResultsPane = ({
isRequest,
Expand All @@ -59,6 +59,14 @@ export const useResultsPane = ({
useEffect(() => {
// it's an invalid formData when gets a errorMessage
if (errorMessage) return;
if (isRequest && cache.has(queryFormData)) {
setResultResp(ensureIsArray(cache.get(queryFormData)));
setResponseError('');
if (queryForce && actions) {
actions.setForceQuery(false);
}
setIsLoading(false);
}
if (isRequest && !cache.has(queryFormData)) {
setIsLoading(true);
getChartDataRequest({
Expand All @@ -71,7 +79,7 @@ export const useResultsPane = ({
.then(({ json }) => {
setResultResp(ensureIsArray(json.result));
setResponseError('');
cache.add(queryFormData);
cache.set(queryFormData, json.result);
if (queryForce && actions) {
actions.setForceQuery(false);
}
Expand Down