Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: datetime value should be seconds in sqlite #21113

Merged
merged 2 commits into from
Aug 18, 2022

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Aug 17, 2022

SUMMARY

The DateTime function returns value in SQLite is not able to do a boolean operation. the SQLite function manual the operand should be a string as 'YYYY-MM-DD HH:MM:SS'.

This PR intends to resolve the issue in D2D.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

This PR has to test on the D2D PR. the dashboard should drill after this PR.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@zhaoyongjie zhaoyongjie marked this pull request as ready for review August 17, 2022 14:26
@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #21113 (004f2e8) into master (394d62e) will decrease coverage by 0.17%.
The diff coverage is 49.15%.

❗ Current head 004f2e8 differs from pull request most recent head 8263b9f. Consider uploading reports for the commit 8263b9f to get more accurate results

@@            Coverage Diff             @@
##           master   #21113      +/-   ##
==========================================
- Coverage   66.27%   66.10%   -0.18%     
==========================================
  Files        1770     1770              
  Lines       67524    67522       -2     
  Branches     7178     7178              
==========================================
- Hits        44754    44637     -117     
- Misses      20936    21051     +115     
  Partials     1834     1834              
Flag Coverage Δ
hive ?
mysql 80.96% <21.62%> (+0.01%) ⬆️
postgres 81.02% <21.62%> (+0.01%) ⬆️
presto ?
python 81.13% <21.62%> (-0.36%) ⬇️
sqlite 79.62% <21.62%> (+0.01%) ⬆️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...set-ui-core/src/ui-overrides/ExtensionsRegistry.ts 100.00% <ø> (ø)
...ns/plugin-chart-echarts/src/Gauge/controlPanel.tsx 66.66% <ø> (ø)
...nd/plugins/plugin-chart-echarts/src/Gauge/types.ts 100.00% <ø> (ø)
superset-frontend/src/components/Radio/index.tsx 100.00% <ø> (ø)
...d/components/DashboardBuilder/DashboardBuilder.tsx 75.00% <ø> (ø)
...frontend/src/dashboard/components/Header/index.jsx 60.29% <ø> (ø)
superset/charts/api.py 85.98% <ø> (ø)
superset/config.py 91.47% <ø> (ø)
superset/examples/bart_lines.py 0.00% <0.00%> (ø)
superset/examples/birth_names.py 71.42% <0.00%> (-0.65%) ⬇️
... and 40 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@codyml codyml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Date filters working in D2D modal with this patch, thanks!

Before:
Screen Shot 2022-08-17 at 12 20 28 PM

After:
Screen Shot 2022-08-17 at 12 20 50 PM

Copy link
Member

@stephenLYZ stephenLYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaoyongjie zhaoyongjie merged commit 1afcdfb into apache:master Aug 18, 2022
@zhaoyongjie zhaoyongjie mentioned this pull request Nov 16, 2022
9 tasks
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants