-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: datetime value should be seconds in sqlite #21113
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21113 +/- ##
==========================================
- Coverage 66.27% 66.10% -0.18%
==========================================
Files 1770 1770
Lines 67524 67522 -2
Branches 7178 7178
==========================================
- Hits 44754 44637 -117
- Misses 20936 21051 +115
Partials 1834 1834
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SUMMARY
The DateTime function returns value in SQLite is not able to do a boolean operation. the SQLite function manual the operand should be a string as 'YYYY-MM-DD HH:MM:SS'.
This PR intends to resolve the issue in D2D.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
This PR has to test on the D2D PR. the dashboard should drill after this PR.
ADDITIONAL INFORMATION