-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: generate label map on the backend #21124
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21124 +/- ##
===========================================
- Coverage 66.32% 54.86% -11.46%
===========================================
Files 1772 1772
Lines 67651 67662 +11
Branches 7205 7205
===========================================
- Hits 44867 37123 -7744
- Misses 20941 28696 +7755
Partials 1843 1843
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
938e957
to
8a47566
Compare
8a47566
to
69db5db
Compare
/testenv up |
@zhaoyongjie Ephemeral environment spinning up at http://54.148.237.28:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM!
Thank you for the PR @zhaoyongjie. I noticed the Screen.Recording.2022-08-22.at.8.35.13.AM.mov |
@michael-s-molina Nice catch! I just realized that Pie has no make Pivot! for now, this feature just supports a chart that contains a pivot operator. I also update the PR description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
Currently, the timeseries chart has a variable
labelMap
, used for mapping result columns(or series) and dimension values. If the result columns contain comma(,
), this mapping can't reverse calculation dimension values on the frontend. This issue was blocked drill to detail.This PR intends to generate
labelMap
on the backend. The frontend only needs to replace thelabelMap
from the chart query response.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Pure backend change, should pass all CI.
ADDITIONAL INFORMATION