-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: timestamp bug for chart-powered-query #21130
fix: timestamp bug for chart-powered-query #21130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we're working on a longer-term fix for this. 🙏
@eschutho yeah all these conditionals make me sad :( |
Codecov Report
@@ Coverage Diff @@
## master #21130 +/- ##
==========================================
- Coverage 66.28% 66.17% -0.11%
==========================================
Files 1770 1770
Lines 67522 68740 +1218
Branches 7177 7177
==========================================
+ Hits 44754 45491 +737
- Misses 20934 21415 +481
Partials 1834 1834
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
/testenv up |
@yousoph Ephemeral environment spinning up at http://34.209.100.203:8080. Credentials are |
/testenv up FEATURE_GENERIC_CHART_AXES=true |
@AAfghahi Ephemeral environment spinning up at http://54.212.195.225:8080. Credentials are |
Ephemeral environment shutdown and build artifacts deleted. |
(cherry picked from commit 252ceb7)
SUMMARY
This fixes a bug when x-axes are turned on for chart powered queries.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2022-08-18.at.4.33.28.PM.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION