Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: timestamp bug for chart-powered-query #21130

Conversation

AAfghahi
Copy link
Member

SUMMARY

This fixes a bug when x-axes are turned on for chart powered queries.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2022-08-18.at.4.33.28.PM.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@AAfghahi AAfghahi requested a review from hughhhh August 18, 2022 20:38
Copy link
Member

@eschutho eschutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're working on a longer-term fix for this. 🙏

@AAfghahi
Copy link
Member Author

@eschutho yeah all these conditionals make me sad :(

@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #21130 (84df3f3) into master (5113b01) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #21130      +/-   ##
==========================================
- Coverage   66.28%   66.17%   -0.11%     
==========================================
  Files        1770     1770              
  Lines       67522    68740    +1218     
  Branches     7177     7177              
==========================================
+ Hits        44754    45491     +737     
- Misses      20934    21415     +481     
  Partials     1834     1834              
Flag Coverage Δ
hive 53.52% <0.00%> (+0.35%) ⬆️
javascript 52.00% <ø> (ø)
mysql 80.95% <0.00%> (-0.01%) ⬇️
postgres 81.00% <0.00%> (-0.01%) ⬇️
presto 53.43% <0.00%> (+0.36%) ⬆️
python 80.73% <0.00%> (-0.76%) ⬇️
sqlite 79.61% <0.00%> (-0.01%) ⬇️
unit 50.88% <0.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/models/helpers.py 39.31% <0.00%> (-0.09%) ⬇️
superset/reports/commands/execute.py 65.09% <0.00%> (-26.33%) ⬇️
superset/reports/notifications/email.py 86.31% <0.00%> (-13.69%) ⬇️
superset/utils/core.py 79.72% <0.00%> (-10.52%) ⬇️
superset/queries/saved_queries/api.py 84.84% <0.00%> (-10.44%) ⬇️
superset/charts/api.py 76.53% <0.00%> (-9.46%) ⬇️
superset/views/base.py 71.10% <0.00%> (-4.26%) ⬇️
superset/examples/birth_names.py 70.06% <0.00%> (-2.01%) ⬇️
superset/result_set.py 96.05% <0.00%> (-1.70%) ⬇️
superset/reports/models.py 98.38% <0.00%> (-1.62%) ⬇️
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yousoph
Copy link
Member

yousoph commented Aug 18, 2022

/testenv up

@github-actions
Copy link
Contributor

@yousoph Ephemeral environment spinning up at http://34.209.100.203:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@AAfghahi
Copy link
Member Author

/testenv up FEATURE_GENERIC_CHART_AXES=true

@github-actions
Copy link
Contributor

@AAfghahi Ephemeral environment spinning up at http://54.212.195.225:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@AAfghahi AAfghahi merged commit 252ceb7 into master Aug 18, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

AnushaErrabelli pushed a commit to preset-io/superset that referenced this pull request Aug 23, 2022
(cherry picked from commit 252ceb7)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the arash.afghahi/sc-55474/chart-power-query-generic-axes-exploring branch March 26, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2022.33 size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants