-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactor FilterableTable to functional component #21136
chore: refactor FilterableTable to functional component #21136
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21136 +/- ##
==========================================
+ Coverage 66.26% 66.32% +0.06%
==========================================
Files 1772 1772
Lines 67649 67659 +10
Branches 7205 7212 +7
==========================================
+ Hits 44825 44877 +52
+ Misses 20981 20939 -42
Partials 1843 1843
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
/testenv up |
@zhaoyongjie Ephemeral environment spinning up at http://34.210.71.87:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the improvement!
Ephemeral environment shutdown and build artifacts deleted. |
I think we should wrap the export in |
SUMMARY
Converted FilterableTable class component into functional component.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
@michael-s-molina @kgabryje @lyndsiWilliams @villebro