Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor FilterableTable to functional component #21136

Merged
merged 1 commit into from
Aug 22, 2022
Merged

chore: refactor FilterableTable to functional component #21136

merged 1 commit into from
Aug 22, 2022

Conversation

EugeneTorap
Copy link
Contributor

SUMMARY

Converted FilterableTable class component into functional component.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API
    @michael-s-molina @kgabryje @lyndsiWilliams @villebro

@codecov
Copy link

codecov bot commented Aug 19, 2022

Codecov Report

Merging #21136 (41c14b9) into master (642a0d7) will increase coverage by 0.06%.
The diff coverage is 74.28%.

❗ Current head 41c14b9 differs from pull request most recent head 66b704c. Consider uploading reports for the commit 66b704c to get more accurate results

@@            Coverage Diff             @@
##           master   #21136      +/-   ##
==========================================
+ Coverage   66.26%   66.32%   +0.06%     
==========================================
  Files        1772     1772              
  Lines       67649    67659      +10     
  Branches     7205     7212       +7     
==========================================
+ Hits        44825    44877      +52     
+ Misses      20981    20939      -42     
  Partials     1843     1843              
Flag Coverage Δ
javascript 52.10% <76.47%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/models/helpers.py 39.31% <0.00%> (-0.09%) ⬇️
...-frontend/src/components/FilterableTable/index.tsx 72.34% <76.47%> (+2.34%) ⬆️
superset/models/core.py 88.75% <0.00%> (+0.23%) ⬆️
superset/connectors/sqla/models.py 90.32% <0.00%> (+0.52%) ⬆️
superset/models/sql_lab.py 77.01% <0.00%> (+2.01%) ⬆️
superset/db_engine_specs/presto.py 87.97% <0.00%> (+6.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zhaoyongjie
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@zhaoyongjie Ephemeral environment spinning up at http://34.210.71.87:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@zhaoyongjie zhaoyongjie self-requested a review August 22, 2022 06:18
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the improvement!

@zhaoyongjie zhaoyongjie merged commit 7c0963f into apache:master Aug 22, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@kgabryje
Copy link
Member

I think we should wrap the export in React.memo to replicate the behaviour of PureComponent from class component

@EugeneTorap EugeneTorap deleted the refactor/FilterableTable-to-fc branch August 22, 2022 12:09
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants