Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(database-modal): Adjusting spacing on database connection form #21167

Merged
merged 3 commits into from
Aug 25, 2022

Conversation

paulo-eduardo
Copy link
Contributor

fix(database-modal): Adjusting spacing on database connection form

SUMMARY

A minor css fix to remove unnecessary bottom margin on 50% fields

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE

Screen.Recording.2022-08-18.at.19.15.29.mov

AFTER

Screen.Recording.2022-08-18.at.19.16.12.mov

TESTING INSTRUCTIONS

  • Click "Data" in the top nav and select "Databases"
  • Click the "+ Database" in the top right corner of the page
  • Select the database that you want to try to connect

@lyndsiWilliams
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@lyndsiWilliams Ephemeral environment spinning up at http://52.12.194.102:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@lyndsiWilliams lyndsiWilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #21167 (ab33751) into master (f77b910) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #21167   +/-   ##
=======================================
  Coverage   66.36%   66.36%           
=======================================
  Files        1781     1781           
  Lines       67871    67871           
  Branches     7239     7239           
=======================================
  Hits        45040    45040           
  Misses      20973    20973           
  Partials     1858     1858           
Flag Coverage Δ
javascript 52.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/views/CRUD/data/database/DatabaseModal/styles.ts 76.69% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@stephenLYZ stephenLYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephenLYZ stephenLYZ merged commit 93557e3 into apache:master Aug 25, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants