-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(database-modal): Adjusting spacing on database connection form #21167
Conversation
/testenv up |
@lyndsiWilliams Ephemeral environment spinning up at http://52.12.194.102:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Codecov Report
@@ Coverage Diff @@
## master #21167 +/- ##
=======================================
Coverage 66.36% 66.36%
=======================================
Files 1781 1781
Lines 67871 67871
Branches 7239 7239
=======================================
Hits 45040 45040
Misses 20973 20973
Partials 1858 1858
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ephemeral environment shutdown and build artifacts deleted. |
fix(database-modal): Adjusting spacing on database connection form
SUMMARY
A minor css fix to remove unnecessary bottom margin on 50% fields
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE
Screen.Recording.2022-08-18.at.19.15.29.mov
AFTER
Screen.Recording.2022-08-18.at.19.16.12.mov
TESTING INSTRUCTIONS