Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: print comment for chromatic storybook link #21170

Merged
merged 14 commits into from
Aug 23, 2022
Merged

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Aug 23, 2022

SUMMARY

Simply print the chromatic generated link whenever the CI is done building

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@pull-request-size pull-request-size bot added size/M and removed size/S labels Aug 23, 2022
@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #21170 (4cc2444) into master (6a0b7e5) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #21170      +/-   ##
==========================================
+ Coverage   66.37%   66.39%   +0.02%     
==========================================
  Files        1781     1781              
  Lines       67871    67871              
  Branches     7239     7239              
==========================================
+ Hits        45047    45064      +17     
+ Misses      20966    20949      -17     
  Partials     1858     1858              
Flag Coverage Δ
hive 53.18% <ø> (ø)
javascript 52.30% <ø> (ø)
mysql 80.98% <ø> (ø)
postgres 81.04% <ø> (ø)
presto 53.07% <ø> (ø)
python 81.52% <ø> (+0.05%) ⬆️
sqlite 79.64% <ø> (?)
unit 50.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/base.py 88.43% <0.00%> (+0.32%) ⬆️
superset/views/core.py 75.60% <0.00%> (+0.60%) ⬆️
superset/result_set.py 97.77% <0.00%> (+1.48%) ⬆️
superset/connectors/sqla/utils.py 88.63% <0.00%> (+2.27%) ⬆️
superset/utils/celery.py 89.65% <0.00%> (+3.44%) ⬆️
superset/db_engine_specs/sqlite.py 97.29% <0.00%> (+5.40%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pull-request-size pull-request-size bot added size/L and removed size/M labels Aug 23, 2022
@hughhhh hughhhh force-pushed the hughhhh-patch-5 branch 2 times, most recently from f9053e2 to 6906e4d Compare August 23, 2022 21:32
@pull-request-size pull-request-size bot added size/M and removed size/L labels Aug 23, 2022
@hughhhh hughhhh closed this Aug 23, 2022
@hughhhh hughhhh reopened this Aug 23, 2022
@github-actions
Copy link
Contributor

Storybook has completed and can be viewed at

@pull-request-size pull-request-size bot added size/S and removed size/M labels Aug 23, 2022
@github-actions
Copy link
Contributor

Storybook has completed and can be viewed at https://62b4d4c211d03654c1992245-uotzsrlobg.chromatic.com/

@hughhhh hughhhh merged commit cda7d70 into master Aug 23, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the hughhhh-patch-5 branch March 26, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants