Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Splitting into two separate chromatic jobs to reduce conditional logic causing run issues #21219

Merged
merged 1 commit into from
Aug 26, 2022
Merged

fix: Splitting into two separate chromatic jobs to reduce conditional logic causing run issues #21219

merged 1 commit into from
Aug 26, 2022

Conversation

eric-briscoe
Copy link
Contributor

SUMMARY

Splitting into two separate chromatic jobs to reduce conditional logic causing run issues

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@eric-briscoe eric-briscoe marked this pull request as ready for review August 26, 2022 21:37
@hughhhh hughhhh changed the title Splitting into two separate chromatic jobs to reduce conditional logic causing run issues feat: Splitting into two separate chromatic jobs to reduce conditional logic causing run issues Aug 26, 2022
@hughhhh hughhhh changed the title feat: Splitting into two separate chromatic jobs to reduce conditional logic causing run issues fix: Splitting into two separate chromatic jobs to reduce conditional logic causing run issues Aug 26, 2022
@hughhhh hughhhh merged commit f09c432 into apache:master Aug 26, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hughhhh hughhhh hughhhh approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eric-briscoe @hughhhh @mistercrunch