From 8dd5522f956daa61df9d4cd495e499c7a038880c Mon Sep 17 00:00:00 2001 From: Eric Briscoe Date: Fri, 26 Aug 2022 16:03:09 -0700 Subject: [PATCH] Update chromatic PR action to have access to Job outputs Adjusting to follow docs at: https://docs.github.com/en/actions/using-jobs/defining-outputs-for-jobs --- .github/workflows/chromatic-pr.yml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/workflows/chromatic-pr.yml b/.github/workflows/chromatic-pr.yml index 52982a8ad9b7b..1ef2646e5a053 100644 --- a/.github/workflows/chromatic-pr.yml +++ b/.github/workflows/chromatic-pr.yml @@ -42,8 +42,13 @@ jobs: chromatic-deployment: # Operating System runs-on: ubuntu-latest + # define outputs that can be used in the storybook-link-comment job + outputs: + storybookUrl: ${{ steps.chromatic-deploy.outputs.storybookUrl }} + buildUrl: ${{ steps.chromatic-deploy.outputs.buildUrl }} # Job steps steps: + - id: chromatic-deploy - uses: actions/checkout@v1 - name: Install dependencies run: npm ci @@ -76,5 +81,5 @@ jobs: issue_number: context.issue.number, owner: context.repo.owner, repo: context.repo.repo, - body: 'Storybook has completed and can be viewed at ${{ needs.chromatic-deployment.outputs.storybookUrl }}. Chromatic visual test results can be viewed at ${{ needs.chromatic-deployment.outputs.buildUrl }} ' + body: 'Storybook has completed and can be viewed at ${{ needs.chromatic-deployment.outputs.storybookUrl }} Chromatic visual test results can be viewed at ${{ needs.chromatic-deployment.outputs.buildUrl }}' })