Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Minor Applitools enhancements #21239

Merged
merged 5 commits into from
Aug 29, 2022
Merged

Conversation

geido
Copy link
Member

@geido geido commented Aug 29, 2022

SUMMARY

Minor Applitools enhancements in preparation for the continuation of the Applitools implementation

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #21239 (db511a2) into master (1d3a805) will not change coverage.
The diff coverage is n/a.

❗ Current head db511a2 differs from pull request most recent head f348a03. Consider uploading reports for the commit f348a03 to get more accurate results

@@           Coverage Diff           @@
##           master   #21239   +/-   ##
=======================================
  Coverage   66.45%   66.45%           
=======================================
  Files        1784     1784           
  Lines       68142    68142           
  Branches     7264     7264           
=======================================
  Hits        45285    45285           
  Misses      20989    20989           
  Partials     1868     1868           
Flag Coverage Δ
javascript 52.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@jinghua-qa jinghua-qa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geido geido merged commit 710a8ce into master Aug 29, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the chore/applitools-enhancements-fixes branch March 26, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants