fix: database modal crashed when use SQLAlchemy URI string #21342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pache#20095) * fix(database): make to display validation error msg when all cases * fix(db): make to update the alert error condition * fix(db): make to add error detail display * fix(db): make to update error alert display by superset error style guide. * fix(db): make to style modal header title with h4 * fix(db): make to place see more on bottom instead of top * fix(db): make to fix shortly * fix(db): make to fix lint issue Co-authored-by: Evan Rusackas <evan@preset.io>
zhaoyongjie
commented
Sep 6, 2022
Comment on lines
1158
to
1160
| description={t(alertErrors[0])} | ||
| subtitle={t(validationErrors?.description)} | ||
| copyText={t(validationErrors?.description)} | ||
| description={alertErrors[0]} | ||
| subtitle={validationErrors?.description} | ||
| copyText={validationErrors?.description} |
There was a problem hiding this comment.
the error message should translate on the backend.
Codecov Report
@@ Coverage Diff @@
## master #21342 +/- ##
==========================================
+ Coverage 66.45% 66.55% +0.09%
==========================================
Files 1789 1790 +1
Lines 68291 68316 +25
Branches 7273 7281 +8
==========================================
+ Hits 45382 45466 +84
+ Misses 21034 20973 -61
- Partials 1875 1877 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR intend to fix an issue from a previous #20095 raised and the PR has reverted by #21277.
Compared with the original PR, only 1 commit has been added. This issue is caused by the translation key cannot find.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION