Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: database modal crashed when use SQLAlchemy URI string #21342

Merged
merged 2 commits into from
Sep 6, 2022
Merged

fix: database modal crashed when use SQLAlchemy URI string #21342

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afd11b5
fix(database): make to display validation error msg when all cases (#…
prosdev0107 Aug 24, 2022
bbdc3bd
fix page crash
zhaoyongjie Sep 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1155,9 +1155,9 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({
return (
<ErrorMessageWithStackTrace
title={t('Database Creation Error')}
description={t(alertErrors[0])}
subtitle={t(validationErrors?.description)}
copyText={t(validationErrors?.description)}
description={alertErrors[0]}
subtitle={validationErrors?.description}
copyText={validationErrors?.description}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the error message should translate on the backend.

/>
);
}
Expand Down