Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix act errors in DndColumnSelect test #21428

Merged
merged 1 commit into from
Sep 10, 2022
Merged

test: Fix act errors in DndColumnSelect test #21428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ...-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnSelect.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,23 +33,23 @@ const defaultProps: DndColumnSelectProps = {
actions: { setControlValue: jest.fn() },
};

test('renders with default props', () => {
test('renders with default props', async () => {
render(<DndColumnSelect {...defaultProps} />, {
useDnd: true,
useRedux: true,
});
expect(screen.getByText('Drop columns here')).toBeInTheDocument();
expect(await screen.findByText('Drop columns here')).toBeInTheDocument();
});

test('renders with value', () => {
test('renders with value', async () => {
render(<DndColumnSelect {...defaultProps} value="string" />, {
useDnd: true,
useRedux: true,
});
expect(screen.getByText('Column A')).toBeInTheDocument();
expect(await screen.findByText('Column A')).toBeInTheDocument();
});

test('renders adhoc column', () => {
test('renders adhoc column', async () => {
render(
<DndColumnSelect
{...defaultProps}
Expand All @@ -61,6 +61,6 @@ test('renders adhoc column', () => {
/>,
{ useDnd: true, useRedux: true },
);
expect(screen.getByText('adhoc column')).toBeVisible();
expect(await screen.findByText('adhoc column')).toBeVisible();
expect(screen.getByLabelText('calculator')).toBeVisible();
});