fix: Supports form_data param in old Explore endpoint #21469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
reviewed
Sep 14, 2022
| url = parse.urlparse(redirect_url) | ||
| query = parse.parse_qs(url.query) | ||
| query.pop("form_data") | ||
| query["form_data_key"] = [form_data_key] |
There was a problem hiding this comment.
From urllib.parse
The dictionary keys are the unique query variable names and the values are lists of values for each name.
It's because most web frameworks allow multiple values to be associated with a single field.
Codecov Report
@@ Coverage Diff @@
## master #21469 +/- ##
=======================================
Coverage 66.59% 66.60%
=======================================
Files 1791 1791
Lines 68555 68577 +22
Branches 7319 7319
=======================================
+ Hits 45654 45673 +19
- Misses 21008 21011 +3
Partials 1893 1893
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
john-bodley
approved these changes
Sep 14, 2022
justinpark
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Sep 16, 2022
(cherry picked from commit 2c7323a)
jinghua-qa
pushed a commit
to preset-io/superset
that referenced
this pull request
Sep 19, 2022
(cherry picked from commit 2c7323a)
jinghua-qa
pushed a commit
to preset-io/superset
that referenced
this pull request
Sep 20, 2022
(cherry picked from commit 2c7323a)
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR improves the support for the
form_dataparam in the old/superset/exploreendpoint. Previously, the old endpoint only redirected the user to the new endpoint with the same original request parameters. Now, ifform_datais present, the endpoint will persist that information in the cache and replace the parameter withform_data_key, the new supported format.Example:
will be redirected to
TESTING INSTRUCTIONS
Check that GET requests to the old endpoint are correctly redirected to the new endpoint with the correct parameters.
ADDITIONAL INFORMATION