From cd96ea3cb272d1981af5e03c17ff86f15362014d Mon Sep 17 00:00:00 2001 From: Evan Rusackas Date: Wed, 14 Sep 2022 20:05:08 -0600 Subject: [PATCH 01/12] Adding missing flags, and a TODO category --- RESOURCES/FEATURE_FLAGS.md | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/RESOURCES/FEATURE_FLAGS.md b/RESOURCES/FEATURE_FLAGS.md index 9ae6a9be53368..f7da6ab49e49c 100644 --- a/RESOURCES/FEATURE_FLAGS.md +++ b/RESOURCES/FEATURE_FLAGS.md @@ -33,6 +33,7 @@ These features are considered **unfinished** and should only be used on developm - SHARE_QUERIES_VIA_KV_STORE - TAGGING_SYSTEM - ENABLE_TEMPLATE_REMOVE_FILTERS +- DRILL_TO_DETAIL ## In Testing These features are **finished** but currently being tested. They are usable, but may still contain some bugs. @@ -44,6 +45,10 @@ These features are **finished** but currently being tested. They are usable, but - VERSIONED_EXPORT - ENABLE_JAVASCRIPT_CONTROLS - GENERIC_CHART_AXES +- ENABLE_FILTER_BOX_MIGRATION +- UX_BETA +- USE_ANALAGOUS_COLORS +- DASHBOARD_EDIT_CHART_IN_NEW_TAB ## Stable These features flags are **safe for production** and have been tested. @@ -57,9 +62,26 @@ These features flags are **safe for production** and have been tested. - SQL_VALIDATORS_BY_ENGINE [(docs)](https://superset.apache.org/docs/installation/sql-templating) - SQLLAB_BACKEND_PERSISTENCE - THUMBNAILS [(docs)](https://superset.apache.org/docs/installation/cache) +- ENABLE_EXPLORE_DRAG_AND_DROP +- ENABLE_DND_WITH_CLICK_UX ## Deprecated Flags These features flags currently default to True and **will be removed in a future major release**. For this current release you can turn them off by setting your config to False, but it is advised to remove or set these flags in your local configuration to **True** so that you do not experience any unexpected changes in a future release. - ALLOW_DASHBOARD_DOMAIN_SHARDING - DISPLAY_MARKDOWN_HTML +- FORCE_DATABASE_CONNECTIONS_SSL + +## In need of categorization (and folks who might know best where to place them) +- DRUID_JOINS (@betodealmeida) +- DISABLE_LEGACY_DATASOURCE_EDITOR (@AAfghahi) +- DASHBOARD_FILTERS_EXPERIMENTAL (@kgabryje) +- EMBEDDED_SUPERSET (@suddjian / @lilykuang) +- ENABLE_ADVANCED_DATA_TYPES (@cccs-RyanS) +- ALERTS_ATTACH_REPORTS (@lilykuang) +- ENFORCE_DB_ENCRYPTION_UI (@AAfghahi) +- ALLOW_FULL_CSV_EXPORT (@m-ajay) +- ALLOW_ADHOC_SUBQUERY (@lilykuang) +- RLS_IN_SQLLAB (@betodealmeida) +- CACHE_IMPERSONATION (@Samira-El) +- EMBEDDABLE_CHARTS (@geido) \ No newline at end of file From 607e5ed167d257a9c282ff439ccfe39126804333 Mon Sep 17 00:00:00 2001 From: Evan Rusackas Date: Wed, 14 Sep 2022 20:11:34 -0600 Subject: [PATCH 02/12] removing handles from the markdown since they're on the PR now. --- RESOURCES/FEATURE_FLAGS.md | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/RESOURCES/FEATURE_FLAGS.md b/RESOURCES/FEATURE_FLAGS.md index f7da6ab49e49c..592ba777f3e0f 100644 --- a/RESOURCES/FEATURE_FLAGS.md +++ b/RESOURCES/FEATURE_FLAGS.md @@ -73,15 +73,15 @@ These features flags currently default to True and **will be removed in a future - FORCE_DATABASE_CONNECTIONS_SSL ## In need of categorization (and folks who might know best where to place them) -- DRUID_JOINS (@betodealmeida) -- DISABLE_LEGACY_DATASOURCE_EDITOR (@AAfghahi) -- DASHBOARD_FILTERS_EXPERIMENTAL (@kgabryje) -- EMBEDDED_SUPERSET (@suddjian / @lilykuang) -- ENABLE_ADVANCED_DATA_TYPES (@cccs-RyanS) -- ALERTS_ATTACH_REPORTS (@lilykuang) -- ENFORCE_DB_ENCRYPTION_UI (@AAfghahi) -- ALLOW_FULL_CSV_EXPORT (@m-ajay) -- ALLOW_ADHOC_SUBQUERY (@lilykuang) -- RLS_IN_SQLLAB (@betodealmeida) -- CACHE_IMPERSONATION (@Samira-El) -- EMBEDDABLE_CHARTS (@geido) \ No newline at end of file +- DRUID_JOINS +- DISABLE_LEGACY_DATASOURCE_EDITOR +- DASHBOARD_FILTERS_EXPERIMENTAL +- EMBEDDED_SUPERSET +- ENABLE_ADVANCED_DATA_TYPES +- ALERTS_ATTACH_REPORTS +- ENFORCE_DB_ENCRYPTION_UI +- ALLOW_FULL_CSV_EXPORT +- ALLOW_ADHOC_SUBQUERY +- RLS_IN_SQLLAB +- CACHE_IMPERSONATION +- EMBEDDABLE_CHARTS \ No newline at end of file From 44dbeafa089134eb3f3b65a4cb50d92517d5bd17 Mon Sep 17 00:00:00 2001 From: Evan Rusackas Date: Wed, 14 Sep 2022 20:13:30 -0600 Subject: [PATCH 03/12] this comment was no longer necessary --- RESOURCES/FEATURE_FLAGS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/RESOURCES/FEATURE_FLAGS.md b/RESOURCES/FEATURE_FLAGS.md index 592ba777f3e0f..dfb57923492f5 100644 --- a/RESOURCES/FEATURE_FLAGS.md +++ b/RESOURCES/FEATURE_FLAGS.md @@ -72,7 +72,7 @@ These features flags currently default to True and **will be removed in a future - DISPLAY_MARKDOWN_HTML - FORCE_DATABASE_CONNECTIONS_SSL -## In need of categorization (and folks who might know best where to place them) +## In need of categorization - DRUID_JOINS - DISABLE_LEGACY_DATASOURCE_EDITOR - DASHBOARD_FILTERS_EXPERIMENTAL From 715c2052a83a04de7056e3ad84862ebb439f2aff Mon Sep 17 00:00:00 2001 From: Evan Rusackas Date: Wed, 14 Sep 2022 22:03:56 -0600 Subject: [PATCH 04/12] linting! --- RESOURCES/FEATURE_FLAGS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/RESOURCES/FEATURE_FLAGS.md b/RESOURCES/FEATURE_FLAGS.md index dfb57923492f5..fd2588d65ce4a 100644 --- a/RESOURCES/FEATURE_FLAGS.md +++ b/RESOURCES/FEATURE_FLAGS.md @@ -84,4 +84,4 @@ These features flags currently default to True and **will be removed in a future - ALLOW_ADHOC_SUBQUERY - RLS_IN_SQLLAB - CACHE_IMPERSONATION -- EMBEDDABLE_CHARTS \ No newline at end of file +- EMBEDDABLE_CHARTS From ae61ad0f54a5d531ebfd5dea3c3fdee24d60d5d1 Mon Sep 17 00:00:00 2001 From: Evan Rusackas Date: Fri, 16 Sep 2022 07:44:26 -0600 Subject: [PATCH 05/12] `EMBEDDABLE_CHARTS` -> Stable Co-authored-by: Geido <60598000+geido@users.noreply.github.com> --- RESOURCES/FEATURE_FLAGS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/RESOURCES/FEATURE_FLAGS.md b/RESOURCES/FEATURE_FLAGS.md index fd2588d65ce4a..bcc7252d9087e 100644 --- a/RESOURCES/FEATURE_FLAGS.md +++ b/RESOURCES/FEATURE_FLAGS.md @@ -64,6 +64,7 @@ These features flags are **safe for production** and have been tested. - THUMBNAILS [(docs)](https://superset.apache.org/docs/installation/cache) - ENABLE_EXPLORE_DRAG_AND_DROP - ENABLE_DND_WITH_CLICK_UX +EMBEDDABLE_CHARTS ## Deprecated Flags These features flags currently default to True and **will be removed in a future major release**. For this current release you can turn them off by setting your config to False, but it is advised to remove or set these flags in your local configuration to **True** so that you do not experience any unexpected changes in a future release. @@ -84,4 +85,3 @@ These features flags currently default to True and **will be removed in a future - ALLOW_ADHOC_SUBQUERY - RLS_IN_SQLLAB - CACHE_IMPERSONATION -- EMBEDDABLE_CHARTS From e2cbd8f3ac975cc4353ebda24fa467843a74ffbb Mon Sep 17 00:00:00 2001 From: Evan Rusackas Date: Sat, 17 Sep 2022 23:18:41 -0600 Subject: [PATCH 06/12] adding a missing dash --- RESOURCES/FEATURE_FLAGS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/RESOURCES/FEATURE_FLAGS.md b/RESOURCES/FEATURE_FLAGS.md index bcc7252d9087e..776f9e987c364 100644 --- a/RESOURCES/FEATURE_FLAGS.md +++ b/RESOURCES/FEATURE_FLAGS.md @@ -64,7 +64,7 @@ These features flags are **safe for production** and have been tested. - THUMBNAILS [(docs)](https://superset.apache.org/docs/installation/cache) - ENABLE_EXPLORE_DRAG_AND_DROP - ENABLE_DND_WITH_CLICK_UX -EMBEDDABLE_CHARTS +- EMBEDDABLE_CHARTS ## Deprecated Flags These features flags currently default to True and **will be removed in a future major release**. For this current release you can turn them off by setting your config to False, but it is advised to remove or set these flags in your local configuration to **True** so that you do not experience any unexpected changes in a future release. From 51f8a2809cc6f3f57b1d033ddea64654308c9fc4 Mon Sep 17 00:00:00 2001 From: Evan Rusackas Date: Mon, 19 Sep 2022 18:17:57 -0600 Subject: [PATCH 07/12] Accepting dev feedback on categorization --- RESOURCES/FEATURE_FLAGS.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/RESOURCES/FEATURE_FLAGS.md b/RESOURCES/FEATURE_FLAGS.md index 776f9e987c364..eb2cb802c0172 100644 --- a/RESOURCES/FEATURE_FLAGS.md +++ b/RESOURCES/FEATURE_FLAGS.md @@ -49,6 +49,9 @@ These features are **finished** but currently being tested. They are usable, but - UX_BETA - USE_ANALAGOUS_COLORS - DASHBOARD_EDIT_CHART_IN_NEW_TAB +- CACHE_IMPERSONATION +- RLS_IN_SQLLAB + ## Stable These features flags are **safe for production** and have been tested. @@ -65,6 +68,7 @@ These features flags are **safe for production** and have been tested. - ENABLE_EXPLORE_DRAG_AND_DROP - ENABLE_DND_WITH_CLICK_UX - EMBEDDABLE_CHARTS +- DRUID_JOINS ## Deprecated Flags These features flags currently default to True and **will be removed in a future major release**. For this current release you can turn them off by setting your config to False, but it is advised to remove or set these flags in your local configuration to **True** so that you do not experience any unexpected changes in a future release. @@ -74,7 +78,6 @@ These features flags currently default to True and **will be removed in a future - FORCE_DATABASE_CONNECTIONS_SSL ## In need of categorization -- DRUID_JOINS - DISABLE_LEGACY_DATASOURCE_EDITOR - DASHBOARD_FILTERS_EXPERIMENTAL - EMBEDDED_SUPERSET @@ -83,5 +86,3 @@ These features flags currently default to True and **will be removed in a future - ENFORCE_DB_ENCRYPTION_UI - ALLOW_FULL_CSV_EXPORT - ALLOW_ADHOC_SUBQUERY -- RLS_IN_SQLLAB -- CACHE_IMPERSONATION From acff33c0dc38662c4a9c1daed85c7ac5e9490294 Mon Sep 17 00:00:00 2001 From: Evan Rusackas Date: Tue, 27 Sep 2022 18:08:42 -0600 Subject: [PATCH 08/12] Apply suggestions from code review Taking DASHBOARD_FILTERS_EXPERIMENTAL at face value - moving to testing --- RESOURCES/FEATURE_FLAGS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/RESOURCES/FEATURE_FLAGS.md b/RESOURCES/FEATURE_FLAGS.md index eb2cb802c0172..21fa08e01f28a 100644 --- a/RESOURCES/FEATURE_FLAGS.md +++ b/RESOURCES/FEATURE_FLAGS.md @@ -51,6 +51,7 @@ These features are **finished** but currently being tested. They are usable, but - DASHBOARD_EDIT_CHART_IN_NEW_TAB - CACHE_IMPERSONATION - RLS_IN_SQLLAB +- DASHBOARD_FILTERS_EXPERIMENTAL ## Stable @@ -79,7 +80,6 @@ These features flags currently default to True and **will be removed in a future ## In need of categorization - DISABLE_LEGACY_DATASOURCE_EDITOR -- DASHBOARD_FILTERS_EXPERIMENTAL - EMBEDDED_SUPERSET - ENABLE_ADVANCED_DATA_TYPES - ALERTS_ATTACH_REPORTS From cd052dc8bcd626687b6abfb77f6c52b8c67ad457 Mon Sep 17 00:00:00 2001 From: Evan Rusackas Date: Wed, 28 Sep 2022 10:57:53 -0600 Subject: [PATCH 09/12] Categorizing 3 more flags (thanks Lily!) --- RESOURCES/FEATURE_FLAGS.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/RESOURCES/FEATURE_FLAGS.md b/RESOURCES/FEATURE_FLAGS.md index 21fa08e01f28a..e22624226b15f 100644 --- a/RESOURCES/FEATURE_FLAGS.md +++ b/RESOURCES/FEATURE_FLAGS.md @@ -69,6 +69,9 @@ These features flags are **safe for production** and have been tested. - ENABLE_EXPLORE_DRAG_AND_DROP - ENABLE_DND_WITH_CLICK_UX - EMBEDDABLE_CHARTS +- EMBEDDED_SUPERSET +- ALERTS_ATTACH_REPORTS +- ALLOW_ADHOC_SUBQUERY - DRUID_JOINS ## Deprecated Flags @@ -80,9 +83,6 @@ These features flags currently default to True and **will be removed in a future ## In need of categorization - DISABLE_LEGACY_DATASOURCE_EDITOR -- EMBEDDED_SUPERSET - ENABLE_ADVANCED_DATA_TYPES -- ALERTS_ATTACH_REPORTS - ENFORCE_DB_ENCRYPTION_UI - ALLOW_FULL_CSV_EXPORT -- ALLOW_ADHOC_SUBQUERY From 18f679472dd6ee45748a0199899d383271b3c285 Mon Sep 17 00:00:00 2001 From: Evan Rusackas Date: Wed, 28 Sep 2022 13:53:37 -0600 Subject: [PATCH 10/12] Two more updates thanks to Arash! --- RESOURCES/FEATURE_FLAGS.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/RESOURCES/FEATURE_FLAGS.md b/RESOURCES/FEATURE_FLAGS.md index e22624226b15f..95831ca195a99 100644 --- a/RESOURCES/FEATURE_FLAGS.md +++ b/RESOURCES/FEATURE_FLAGS.md @@ -73,6 +73,8 @@ These features flags are **safe for production** and have been tested. - ALERTS_ATTACH_REPORTS - ALLOW_ADHOC_SUBQUERY - DRUID_JOINS +- DISABLE_LEGACY_DATASOURCE_EDITOR +- ENFORCE_DB_ENCRYPTION_UI ## Deprecated Flags These features flags currently default to True and **will be removed in a future major release**. For this current release you can turn them off by setting your config to False, but it is advised to remove or set these flags in your local configuration to **True** so that you do not experience any unexpected changes in a future release. @@ -82,7 +84,5 @@ These features flags currently default to True and **will be removed in a future - FORCE_DATABASE_CONNECTIONS_SSL ## In need of categorization -- DISABLE_LEGACY_DATASOURCE_EDITOR - ENABLE_ADVANCED_DATA_TYPES -- ENFORCE_DB_ENCRYPTION_UI - ALLOW_FULL_CSV_EXPORT From 9ebe546a495c1713f765a98d915b38dc74de9f8d Mon Sep 17 00:00:00 2001 From: Evan Rusackas Date: Wed, 28 Sep 2022 14:02:13 -0600 Subject: [PATCH 11/12] Another one resolved thanks to Ryan! --- RESOURCES/FEATURE_FLAGS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/RESOURCES/FEATURE_FLAGS.md b/RESOURCES/FEATURE_FLAGS.md index 95831ca195a99..29bbba4168ea8 100644 --- a/RESOURCES/FEATURE_FLAGS.md +++ b/RESOURCES/FEATURE_FLAGS.md @@ -34,6 +34,7 @@ These features are considered **unfinished** and should only be used on developm - TAGGING_SYSTEM - ENABLE_TEMPLATE_REMOVE_FILTERS - DRILL_TO_DETAIL +- ENABLE_ADVANCED_DATA_TYPES ## In Testing These features are **finished** but currently being tested. They are usable, but may still contain some bugs. @@ -84,5 +85,4 @@ These features flags currently default to True and **will be removed in a future - FORCE_DATABASE_CONNECTIONS_SSL ## In need of categorization -- ENABLE_ADVANCED_DATA_TYPES - ALLOW_FULL_CSV_EXPORT From 8037e699205972019f8fb70dc83e2154502b7793 Mon Sep 17 00:00:00 2001 From: Evan Rusackas Date: Thu, 29 Sep 2022 07:48:30 -0600 Subject: [PATCH 12/12] ALLOW_FULL_CSV_EXPORT moved to testing due to apparent risks --- RESOURCES/FEATURE_FLAGS.md | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/RESOURCES/FEATURE_FLAGS.md b/RESOURCES/FEATURE_FLAGS.md index 29bbba4168ea8..fb2a6c07189b5 100644 --- a/RESOURCES/FEATURE_FLAGS.md +++ b/RESOURCES/FEATURE_FLAGS.md @@ -53,6 +53,7 @@ These features are **finished** but currently being tested. They are usable, but - CACHE_IMPERSONATION - RLS_IN_SQLLAB - DASHBOARD_FILTERS_EXPERIMENTAL +- ALLOW_FULL_CSV_EXPORT ## Stable @@ -83,6 +84,3 @@ These features flags currently default to True and **will be removed in a future - ALLOW_DASHBOARD_DOMAIN_SHARDING - DISPLAY_MARKDOWN_HTML - FORCE_DATABASE_CONNECTIONS_SSL - -## In need of categorization -- ALLOW_FULL_CSV_EXPORT