-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create table component based on ant design Table #21520
feat: create table component based on ant design Table #21520
Conversation
Very rough starting point for new table component
…sign system overview mdx, and Table overview mdx
…g drop code into separate class
…tation, fixes re-orderable drag drop columns issue
Codecov Report
@@ Coverage Diff @@
## master #21520 +/- ##
==========================================
+ Coverage 67.07% 67.09% +0.01%
==========================================
Files 1815 1827 +12
Lines 69575 69876 +301
Branches 7486 7548 +62
==========================================
+ Hits 46665 46880 +215
- Misses 20974 21040 +66
- Partials 1936 1956 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
superset-frontend/src/components/Table/utils/InteractiveTableUtils.ts
Outdated
Show resolved
Hide resolved
superset-frontend/src/components/Table/cell-renderers/ButtonCell/ButtonCell.stories.tsx
Outdated
Show resolved
Hide resolved
Approved but have a few questions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went through and found some things/had some questions. I also noticed that a storybook log was pushed up to superset-frontend/build-storybook.log
. I don't see storybook logs elsewhere in the codebase, was this log meant to be part of this PR?
superset-frontend/src/components/Table/utils/InteractiveTableUtils.ts
Outdated
Show resolved
Hide resolved
superset-frontend/src/components/Table/utils/InteractiveTableUtils.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
…ell/index.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
…ell/index.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
…ll/ActionCell.overview.mdx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
…ll/ActionCell.overview.mdx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
…ll/ActionCell.overview.mdx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
superset-frontend/src/components/Table/utils/InteractiveTableUtils.ts
Outdated
Show resolved
Hide resolved
superset-frontend/src/components/Table/utils/InteractiveTableUtils.ts
Outdated
Show resolved
Hide resolved
superset-frontend/src/components/Table/utils/InteractiveTableUtils.ts
Outdated
Show resolved
Hide resolved
@lyndsiWilliams I removed that file, thanks for catching that! |
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
…t was called from
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for all the hard work and for addressing the comments @eric-briscoe!
…based on PR question
Thank you for the thorough reviews @michael-s-molina @lyndsiWilliams @AAfghahi @pkdotson 😄 |
Adds a new Table component based on Ant Design as part of movement to a Superset Design system
SUMMARY
To view the table component and see the documentation:
https://75b68f5--62b4d4c211d03654c1992245.chromatic.com/?path=/story/design-system-components-table-overview--page (manually updating to Chromatic)
To run local:
npm ci
npm run storybook
This provides the documentation to use the new Table component as well as interactive stories to see the behavior of the various props
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION