Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Organizes the Select files #21589

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Organizes the Select files. No functional changes.

  • Extracts types to a types.ts file
  • Extracts styles to a styles.tsx file
  • Extracts the async stories to its own file

@cccs-RyanK

TESTING INSTRUCTIONS

1 - Execute all tests
2 - All tests should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Merging #21589 (6a19e26) into master (5d51555) will increase coverage by 0.00%.
The diff coverage is 74.11%.

❗ Current head 6a19e26 differs from pull request most recent head 8f041ea. Consider uploading reports for the commit 8f041ea to get more accurate results

@@           Coverage Diff           @@
##           master   #21589   +/-   ##
=======================================
  Coverage   66.65%   66.66%           
=======================================
  Files        1794     1796    +2     
  Lines       68692    68709   +17     
  Branches     7308     7311    +3     
=======================================
+ Hits        45789    45804   +15     
- Misses      21035    21043    +8     
+ Partials     1868     1862    -6     
Flag Coverage Δ
javascript 52.92% <74.62%> (+0.10%) ⬆️
mysql ?
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/packages/superset-ui-chart-controls/src/index.ts 100.00% <ø> (ø)
...chart-controls/src/shared-controls/dndControls.tsx 58.33% <ø> (+4.76%) ⬆️
...src/BigNumber/BigNumberWithTrendline/buildQuery.ts 0.00% <0.00%> (ø)
.../BigNumber/BigNumberWithTrendline/controlPanel.tsx 16.66% <0.00%> (-8.34%) ⬇️
...set-frontend/src/components/Select/AsyncSelect.tsx 87.70% <ø> (-0.27%) ⬇️
superset-frontend/src/components/Select/Select.tsx 92.55% <ø> (ø)
superset-frontend/src/components/Select/utils.tsx 81.48% <ø> (+5.39%) ⬆️
...e/components/controls/SelectAsyncControl/index.tsx 54.83% <ø> (ø)
...lUtils/getControlValuesCompatibleWithDatasource.ts 8.00% <0.00%> (+0.30%) ⬆️
superset-frontend/src/views/components/SubMenu.tsx 86.88% <ø> (ø)
... and 31 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@ktmud ktmud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

superset-frontend/src/components/Select/utils.tsx Outdated Show resolved Hide resolved
@michael-s-molina michael-s-molina merged commit bb1cf7f into apache:master Sep 27, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XXL 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants