-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: gsheets editing with dynamic forms #21710
Conversation
cf98ad3
to
19ba4a0
Compare
19ba4a0
to
b76003d
Compare
Codecov Report
@@ Coverage Diff @@
## master #21710 +/- ##
==========================================
- Coverage 66.85% 66.84% -0.01%
==========================================
Files 1799 1799
Lines 68887 68896 +9
Branches 7320 7322 +2
==========================================
+ Hits 46052 46055 +3
- Misses 20946 20951 +5
- Partials 1889 1890 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
/testenv up |
@hughhhh Container image not yet published for this PR. Please try again when build is complete. |
@hughhhh Ephemeral environment creation failed. Please check the Actions logs for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can clean this up more in the future to have the structure match the db model instead of having catalog at the root.
b3b5024
to
28de5f0
Compare
28de5f0
to
feafb35
Compare
Yeah, I think ideally this would just live inside the extra field in the payload (mimicking how it's stored in the database), and the frontend would move it to a custom field as needed. Having db-specific fields to the root can quickly pollute the interface. |
@@ -744,7 +746,10 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({ | |||
}); | |||
} | |||
|
|||
setDB({ type: ActionType.addTableCatalogSheet }); | |||
if (database_name === 'Google Sheets') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be checking for the engine/backend instead of the DB Name which might be changed by users?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part happens before the user names it, but I agree.. the engine would also work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'll make a follow up PR with the enums of the engines so we can leverage that for checking vs. the string
(cherry picked from commit 882bfb6)
SUMMARY
Change reference for grabbing data for gsheets validation. Now,
catalog
data lives in the root instead of in parameters in our client code.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION