-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove several React app console warnings and errors v2 #21725
Conversation
Remove required requirement on multiple optional fields Fix errors in wrongly nested HTML elements
Codecov Report
@@ Coverage Diff @@
## master #21725 +/- ##
=======================================
Coverage 66.95% 66.95%
=======================================
Files 1807 1807
Lines 69196 69199 +3
Branches 7402 7402
=======================================
+ Hits 46331 46334 +3
Misses 20954 20954
Partials 1911 1911
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Thanks for the work, can we resolve the conflicting files? |
# Conflicts: # superset-frontend/src/views/CRUD/chart/ChartList.tsx
@stephenLYZ done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
SUMMARY
Remove several warnings and errors all around the React app.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
Visit pages in:
ADDITIONAL INFORMATION