fix(explore): Persist URL params to form-data

[john-bodley]

SUMMARY

This PR fixes a regression introduced in #20399 where the URL parameters—which are defined in the request arguments—were not persisted to the form-data, i.e., the code did not adhere the the existing logic defined in the soon to be deprecated legacy endpoint here.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Added unit tests.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[john-bodley]

No need for misdirection.

[codecov]

Codecov Report

Merging #21792 (5d2b738) into master (75e6a04) will increase coverage by 0.74%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #21792      +/-   ##
==========================================
+ Coverage   66.11%   66.86%   +0.74%     
==========================================
  Files        1803     1803              
  Lines       68996    68997       +1     
  Branches     7349     7349              
==========================================
+ Hits        45616    46132     +516     
+ Misses      21487    20972     -515     
  Partials     1893     1893              

Flag	Coverage Δ
hive	52.92% <33.33%> (-0.01%)	⬇️
mysql	78.25% <100.00%> (?)
postgres	78.31% <100.00%> (?)
presto	52.82% <33.33%> (-0.01%)	⬇️
python	81.45% <100.00%> (+1.54%)	⬆️
sqlite	76.80% <100.00%> (-0.01%)	⬇️
unit	51.07% <66.66%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/explore/commands/get.py	90.52% <100.00%> (+0.10%)	⬆️
superset/migrations/shared/utils.py	35.48% <0.00%> (-0.59%)	⬇️
superset/models/slice.py	86.13% <0.00%> (-0.07%)	⬇️
superset/db_engine_specs/base.py	89.69% <0.00%> (+0.15%)	⬆️
superset/views/core.py	76.06% <0.00%> (+0.45%)	⬆️
superset/common/query_object.py	94.38% <0.00%> (+0.51%)	⬆️
superset/connectors/sqla/models.py	90.73% <0.00%> (+0.51%)	⬆️
superset/commands/importers/v1/utils.py	93.50% <0.00%> (+1.29%)	⬆️
superset/models/core.py	90.11% <0.00%> (+1.41%)	⬆️
superset/views/base_api.py	98.44% <0.00%> (+1.55%)	⬆️
... and 28 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[michael-s-molina]

LGTM. Thanks for the fix!

[michael-s-molina]

Sadly there doesn't seem to be any unit/integration tests which specifically test the GetExploreCommand class.

The tests are in tests/integration_tests/explore/api_tests.py. The API only supports GET.

[john-bodley]

Thanks for the tip @michael-s-molina. I added a test.