Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow comma in Number Format #21817

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Conversation

geido
Copy link
Member

@geido geido commented Oct 14, 2022

SUMMARY

This PR removes the comma from the token separators for the Number Format control so that it would be possible to create values that include commas.

AFTER

DEV.Superset.1.mp4

TESTING INSTRUCTIONS

  1. Open a Pie Chart
  2. Open the Customize tab
  3. Enter a value that includes commas in the Number Format control
  4. It should be possible to add commas

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #21817 (1aaf609) into master (df3b5a8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #21817   +/-   ##
=======================================
  Coverage   66.85%   66.85%           
=======================================
  Files        1805     1805           
  Lines       69061    69061           
  Branches     7369     7369           
=======================================
  Hits        46169    46169           
  Misses      20995    20995           
  Partials     1897     1897           
Flag Coverage Δ
hive 52.92% <ø> (ø)
javascript 53.21% <ø> (ø)
mysql 78.24% <ø> (ø)
postgres 78.30% <ø> (ø)
presto 52.82% <ø> (ø)
python 81.45% <ø> (ø)
sqlite 76.79% <ø> (ø)
unit 51.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...gins/plugin-chart-echarts/src/Pie/controlPanel.tsx 28.57% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@geido geido merged commit 383dc29 into master Oct 18, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the fix/comma-separator-number-format branch March 26, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants