fix: Unhandled exception Str Column Type

[sinhashubham95]

SUMMARY

The metric is a list of Any, so that may or may not have the attribute get. This pull request adds a check for that and avoids the APIs using the same throwing internal server error.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

NA

TESTING INSTRUCTIONS

NA

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[sinhashubham95]

@villebro can you please check this?

[codecov]

Codecov Report

Merging #22147 (8ec8622) into master (394fb2f) will increase coverage by 13.77%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master   #22147       +/-   ##
===========================================
+ Coverage   53.22%   67.00%   +13.77%     
===========================================
  Files        1833     1833               
  Lines       69935    69932        -3     
  Branches     7571     7571               
===========================================
+ Hits        37221    46855     +9634     
+ Misses      30755    21118     -9637     
  Partials     1959     1959               

Flag	Coverage Δ
hive	52.60% <0.00%> (+<0.01%)	⬆️
mysql	78.14% <100.00%> (?)
postgres	78.21% <100.00%> (?)
presto	52.50% <0.00%> (?)
python	81.39% <100.00%> (+28.79%)	⬆️
sqlite	76.66% <100.00%> (?)
unit	50.90% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/connectors/base/models.py	87.12% <100.00%> (+22.66%)	⬆️
superset/config.py	91.84% <0.00%> (+0.62%)	⬆️
superset/views/database/views.py	31.36% <0.00%> (+0.90%)	⬆️
superset/reports/models.py	100.00% <0.00%> (+2.00%)	⬆️
superset/initialization/__init__.py	91.00% <0.00%> (+2.00%)	⬆️
superset/databases/commands/exceptions.py	96.92% <0.00%> (+3.07%)	⬆️
superset/migrations/shared/utils.py	35.48% <0.00%> (+3.22%)	⬆️
superset/sql_lab.py	82.12% <0.00%> (+3.42%)	⬆️
superset/exceptions.py	91.30% <0.00%> (+3.47%)	⬆️
superset/charts/data/commands/get_data_command.py	100.00% <0.00%> (+3.70%)	⬆️
... and 324 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[villebro]

On line 314 we're already calling a type guard making sure that the type is in fact AdhocMetric. So it appears there may be something wrong either in the declaration of the AdhocMetric type or the type guard. Can you post the full stack trace of the error you're seeing and see if we need to update either one of those instead?

[sinhashubham95]

@villebro sorry for the late reply. As you mentioned correctly, I missed the check for AdhocMetric. The issue was not with metric param, rather with column. Added a check around that.

[sinhashubham95]

@villebro please check.

[villebro]

One minor improvement proposal to further simplify the code

[sinhashubham95]

@villebro applied the requested changes. Please check.

[villebro]

LGTM, thanks for the fix!