Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Flaky E2E tests #22152

Merged
merged 3 commits into from
Nov 18, 2022
Merged

fix: Flaky E2E tests #22152

merged 3 commits into from
Nov 18, 2022

Conversation

geido
Copy link
Member

@geido geido commented Nov 17, 2022

SUMMARY

This PR attempts to fix some of the most recent flaky E2E tests of high and medium severity.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N.A.

TESTING INSTRUCTIONS

All E2E tests should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@geido geido requested a review from jinghua-qa as a code owner November 17, 2022 15:53
@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #22152 (786f779) into master (394fb2f) will increase coverage by 13.81%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #22152       +/-   ##
===========================================
+ Coverage   53.22%   67.03%   +13.81%     
===========================================
  Files        1833     1836        +3     
  Lines       69935    70294      +359     
  Branches     7571     7683      +112     
===========================================
+ Hits        37221    47121     +9900     
+ Misses      30755    21184     -9571     
- Partials     1959     1989       +30     
Flag Coverage Δ
hive 52.60% <ø> (ø)
javascript 54.01% <ø> (+0.22%) ⬆️
postgres 78.19% <ø> (?)
presto 52.49% <ø> (?)
python 81.34% <ø> (+28.74%) ⬆️
sqlite 76.65% <ø> (?)
unit 50.89% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ts/nativeFilters/FilterBar/ActionButtons/index.tsx 80.95% <0.00%> (-6.55%) ⬇️
...board/components/nativeFilters/FilterBar/index.tsx 58.37% <0.00%> (-2.06%) ⬇️
...et-frontend/src/components/TableView/TableView.tsx 83.69% <0.00%> (-0.62%) ⬇️
...frontend/src/components/DatabaseSelector/index.tsx 92.30% <0.00%> (-0.23%) ⬇️
...nd/src/components/DropdownSelectableIcon/index.tsx 100.00% <0.00%> (ø)
...rd/components/nativeFilters/FilterBar/Vertical.tsx 72.91% <0.00%> (ø)
.../components/nativeFilters/FilterBar/Horizontal.tsx 100.00% <0.00%> (ø)
...ers/FilterBar/FilterBarOrientationSelect/index.tsx 92.85% <0.00%> (ø)
superset/config.py 91.84% <0.00%> (+0.62%) ⬆️
superset/views/database/views.py 31.36% <0.00%> (+0.90%) ⬆️
... and 335 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jinghua-qa jinghua-qa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geido geido closed this Nov 18, 2022
@geido geido reopened this Nov 18, 2022
@geido geido merged commit e990690 into master Nov 18, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the fix/flaky-e2e-test-high-medium branch March 26, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants