Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): Fix hover labels for horizontal overflow native filter dividers #22210

Merged
merged 2 commits into from
Nov 28, 2022

Conversation

codyml
Copy link
Member

@codyml codyml commented Nov 23, 2022

SUMMARY

This PR is based on #22169 and fixes hover labels that weren't appearing for dividers in horizontal native filters overflow dropdown.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
Screen Shot 2022-11-23 at 3 08 58 PM

After:
Screen Shot 2022-11-23 at 3 08 30 PM
Screen Shot 2022-11-23 at 3 08 41 PM

TESTING INSTRUCTIONS

  • Ensure that dividers in the horizontal overflow dropdown show tooltips for titles and descriptions that are truncated.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags: HORIZONTAL_FILTER_BAR
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codyml codyml marked this pull request as draft November 23, 2022 22:11
@codyml codyml changed the title [WIP] fix(dashboard): Fix hover labels for horizontal overflow native filter dividers fix(dashboard): Fix hover labels for horizontal overflow native filter dividers Nov 23, 2022
@kgabryje kgabryje marked this pull request as ready for review November 25, 2022 11:29
Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Merging #22210 (a7ec2d2) into master (64939f2) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master   #22210      +/-   ##
==========================================
- Coverage   66.91%   66.90%   -0.02%     
==========================================
  Files        1839     1839              
  Lines       70079    70084       +5     
  Branches     7636     7638       +2     
==========================================
- Hits        46894    46890       -4     
- Misses      21218    21220       +2     
- Partials     1967     1974       +7     
Flag Coverage Δ
javascript 53.74% <66.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nd/src/hooks/useTruncation/useCSSTextTruncation.ts 69.23% <55.55%> (-30.77%) ⬇️
...Filters/FilterBar/FilterControls/FilterDivider.tsx 81.48% <100.00%> (-18.52%) ⬇️
...s/legacy-plugin-chart-country-map/src/countries.ts 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kgabryje kgabryje merged commit 93158ea into apache:master Nov 28, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants