chore(dashboard): Ignore empty json value for overwrite confirm #22214
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Minor regression from #21819
When user change a single layout but no filter_scope updates, there's unrelated overwrite confirmation kept popping up because the default json value is not empty string but an empty object
{}
.This commit updates the default json value to skip the unnecessary overwrite warning.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
ignore-empty-json-overwrite.mov
After:
No overwrite confirm
TESTING INSTRUCTIONS
CONFIRM_DASHBOARD_DIFF
ADDITIONAL INFORMATION
cc: @ktmud @john-bodley